Skip to content

Feature/183 add vendor to useragent #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 22, 2025
Merged

Feature/183 add vendor to useragent #184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
94977d1
Update `SDK_USER_AGENT` constant to include vendor name in `ApiClient`
mesilov Jun 22, 2025
38c0866
Add `lint-all` target to Makefile for sequential linting tasks
mesilov Jun 22, 2025
f0280b6
Update CHANGELOG to reflect user agent prefix change in B24-PHP-SDK
mesilov Jun 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,13 +86,16 @@
- `get` get localizations
- `fields` get localization fields
- `delete` delete currency, with batch calls support
- Developer experience: added make command `lint-all` for run all code linters step by step, [see details](https://github.com/bitrix24/b24phpsdk/issues/183)

### Fixed

- Fixed error in arguments in service for method `placement.bind`, [see details](https://github.com/bitrix24/b24phpsdk/issues/151)
- Fixed errors in `task.elapseditem.*` call in ApiClient [see details](https://github.com/bitrix24/b24phpsdk/issues/180)
- Fixed errors in `task.elapseditem.*` call in ApiClient [see details](https://github.com/bitrix24/b24phpsdk/issues/180)

### Changed

- Changed B24-PHP-SDK useragent: added prefix `vendor`, [see details](https://github.com/bitrix24/b24phpsdk/issues/183)
- ❗**️️BC** Changed contract `Bitrix24\SDK\Application\Contracts\Bitrix24Accounts\Entity\Bitrix24AccountInterface`, this change needs to process corner cases
when [installed application with UI or without UI](https://github.com/bitrix24/b24phpsdk/issues/150):
- changed method `public function applicationInstalled(?string $applicationToken): void` application token now is nullable
Expand Down
4 changes: 4 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ help:
@echo "ngrok-up - start ngrok"
@echo "ngrok-down - stop ngrok"
@echo ""
@echo "lint-all - lint codebase with all linters step by step"
@echo "lint-allowed-licenses - lint dependencies for valid licenses"
@echo "lint-cs-fixer - lint source code with php-cs-fixer"
@echo "lint-cs-fixer-fix - fix source code with php-cs-fixer"
Expand Down Expand Up @@ -133,6 +134,9 @@ lint-rector:
lint-rector-fix:
docker-compose run --rm php-cli vendor/bin/rector process

.PHONY: lint-all
lint-all: lint-allowed-licenses lint-cs-fixer lint-phpstan lint-rector

# unit tests
.PHONY: test-unit
test-unit:
Expand Down
2 changes: 1 addition & 1 deletion src/Core/ApiClient.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ class ApiClient implements ApiClientInterface
*/
protected const SDK_VERSION = '1.3.0';

protected const SDK_USER_AGENT = 'b24-php-sdk';
protected const SDK_USER_AGENT = 'b24-php-sdk-vendor';

/**
* ApiClient constructor.
Expand Down