Skip to content

Conversation

@younesbelkada
Copy link
Collaborator

What does this PR do?

As per title, this PR adds a stale bot to the library in order to filter out old issues

The scripts and workflow are copied and adapted from : https://github.com/huggingface/trl/blob/main/scripts/stale.py

Read more about the GITHUB_TOKEN secret here: https://docs.github.com/en/actions/security-guides/automatic-token-authentication

cc @Titus-von-Koeller @TimDettmers

@Titus-von-Koeller
Copy link
Collaborator

LGTM, thanks @younesbelkada, great input 🤗🤘🏼

@Titus-von-Koeller Titus-von-Koeller merged commit 2603cad into main Dec 19, 2023
@younesbelkada younesbelkada deleted the add-stale-bot branch December 19, 2023 08:42
jph00 pushed a commit to jph00/bitsandbytes that referenced this pull request Jan 4, 2024
@tomaarsen
Copy link
Contributor

Heya you two!

I recognize that this stale bot has been removed now, but I am curious in it for my own purposes - this implementation feels a bit "manual", i.e. a normal cron script that runs a manually included Python script to mark as stale, close issues, etc.

On the other hand, there is also the stale GitHub action. Do you know why this manual version was chosen rather than the GitHub action? I was planning on using the GitHub action, but if there's something lacking/suboptimal in that one, then I'd love to know about it before I affect hundreds of issues 😄

  • Tom Aarsen

@Titus-von-Koeller
Copy link
Collaborator

Hey @tomaarsen,

Great to hear from you! Maybe we should have a coffee sometime, as we seem to be struggling with similar things :)

I was hoping @younesbelkada would answer because he was the one that brought forward the implementation as it currently is. My understanding is that we took the best practice from Transformers and just applied it without changes here.

As to whether this is better over the default Github action, I'm not sure. But looking at the link you provided, it seems to me like it offers a bunch more options to fine-tune what's happening. Maybe we should also switch over to this for bitsandbytes. I would agree that for you the officially supported GitHub action is likely a better way forward.

For now it solved our immediate issue of needing to draw a line somewhere when trying to get on top of overdue maintenance + prioritize. It's still pretty hard the way it currently is, even without looking at the old stuff and hoping that someone reopens, if it's still important.

@tomaarsen
Copy link
Contributor

Haha that sounds great 😄

I especially like the idea of the GitHub one as you can seemingly limit the number of actions and you can specify how frequently it must run. That means, I should be able to configure it to stale only ~10 issues per day, only on weekdays, and then I can manually look at the staled issues myself to potentially un-stale them.

I'll have a look at this for Sentence Transformers in the coming days most likely, and I'll let you know how it goes :)

@Titus-von-Koeller
Copy link
Collaborator

Titus-von-Koeller commented Jan 26, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants