Commit 333ece2
committed
test(daemon-server): blocker must use Node's default listen host to match the daemon
Previous attempt bound the blocker to 0.0.0.0, but Node's default when no
host is passed to server.listen() is the IPv6 wildcard `::` with
IPV6_V6ONLY=true. On macOS and Windows, `::` (IPv6-only) and `0.0.0.0`
(IPv4) do not conflict, so the daemon's bind succeeded and the assertion
failed. Drop the explicit host on the blocker too so it lands on the same
default as express.listen(port) — `::` on dual-stack runners.1 parent 0d90f0f commit 333ece2
1 file changed
Lines changed: 6 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | | - | |
18 | | - | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
27 | | - | |
| 27 | + | |
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
| |||
0 commit comments