-
Notifications
You must be signed in to change notification settings - Fork 78
[PM-26248] Add plurals #1999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[PM-26248] Add plurals #1999
Conversation
Thank you for your contribution! We've added this to our internal tracking system for review. Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process. |
AuthenticatorShared/Core/Platform/Models/Enum/ClearClipboardValue.swift
Outdated
Show resolved
Hide resolved
BitwardenResources/Localizations/en.lproj/Localizable.stringsdict
Outdated
Show resolved
Hide resolved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1999 +/- ##
==========================================
- Coverage 85.29% 85.29% -0.01%
==========================================
Files 1691 1691
Lines 144250 144248 -2
==========================================
- Hits 123044 123042 -2
Misses 21206 21206 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🤔 It looks like some other issues have come up with conflicts and the like. Do you mind if I take this PR and run with it (though probably in a separate PR because GitHub, I'll have to see) to clean some remaining stuff up and get all the ducks in a row? |
Feel free to edit! |
Great job! No new security vulnerabilities introduced in this pull request |
After spending some time futzing with git and the code, I determined that I thought it would be easier to break out adding these plurals into a couple PRs, potentially, so as to get a more-focused look at them, and handle some ancillary improvements that can be made at the same time. I'll still keep this open as a way of keeping tabs on what still might need to be migrated, as we can keep merging |
🎟️ Tracking
#1912
📔 Objective
I added plurals by stringsdict file.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes