Skip to content

Conversation

mKoonrad
Copy link
Contributor

🎟️ Tracking

#1912

📔 Objective

I added plurals by stringsdict file.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@mKoonrad mKoonrad requested review from a team and matt-livefront as code owners September 28, 2025 22:57
@bitwarden-bot
Copy link

Thank you for your contribution! We've added this to our internal tracking system for review.
ID: PM-26248
Link: https://bitwarden.atlassian.net/browse/PM-26248

Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process.

@bitwarden-bot bitwarden-bot changed the title Add plurals [PM-26248] Add plurals Sep 28, 2025
Copy link

codecov bot commented Oct 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.29%. Comparing base (41181fc) to head (5ce1221).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1999      +/-   ##
==========================================
- Coverage   85.29%   85.29%   -0.01%     
==========================================
  Files        1691     1691              
  Lines      144250   144248       -2     
==========================================
- Hits       123044   123042       -2     
  Misses      21206    21206              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@KatherineInCode
Copy link
Contributor

🤔 It looks like some other issues have come up with conflicts and the like. Do you mind if I take this PR and run with it (though probably in a separate PR because GitHub, I'll have to see) to clean some remaining stuff up and get all the ducks in a row?

@mKoonrad
Copy link
Contributor Author

Feel free to edit!

Copy link
Contributor

github-actions bot commented Oct 17, 2025

Logo
Checkmarx One – Scan Summary & Details3eb2d9df-2a7f-43ce-b051-3147369306b7

Great job! No new security vulnerabilities introduced in this pull request

@KatherineInCode
Copy link
Contributor

After spending some time futzing with git and the code, I determined that I thought it would be easier to break out adding these plurals into a couple PRs, potentially, so as to get a more-focused look at them, and handle some ancillary improvements that can be made at the same time. I'll still keep this open as a way of keeping tabs on what still might need to be migrated, as we can keep merging main into it, which should hopefully Just Work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants