Skip to content

Conversation

@matt-livefront
Copy link
Collaborator

@matt-livefront matt-livefront commented Sep 29, 2025

🎟️ Tracking

PM-24939

📔 Objective

Allow adding a new item when autofilling from the Autofill context menu. We don't support prefilling any fields like URLs in this case, but it at least allows a user to generate and use a password from the autofill extension.

Fixes #1868

📸 Screenshots

ScreenRecording_09-29-2025.16-00-26_1.MP4

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@matt-livefront matt-livefront requested a review from a team as a code owner September 29, 2025 21:18
@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsee5b4b47-be8e-4f42-bf97-bb990a5a8439

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Sep 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.33%. Comparing base (9f0c578) to head (e18fd78).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2006      +/-   ##
==========================================
+ Coverage   81.29%   81.33%   +0.03%     
==========================================
  Files         822      823       +1     
  Lines       52015    52136     +121     
==========================================
+ Hits        42284    42403     +119     
- Misses       9731     9733       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@matt-livefront matt-livefront merged commit db7cca7 into main Sep 30, 2025
10 checks passed
@matt-livefront matt-livefront deleted the matt/PM-24939-autofill-add-item branch September 30, 2025 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[PM-24939] New Item Button missing on Autofill

2 participants