Skip to content

Conversation

fedemkr
Copy link
Member

@fedemkr fedemkr commented Oct 3, 2025

🎟️ Tracking

PM-25992

📔 Objective

Fix to refresh the access token when a .syncOrgKeys notification is received so if token claims change the app doesn't throw errors on certain operations.

This fixes an issue where the user is already signed in the app, then it gets invited and confirmed into an organization. So then after a sync the user sees new collections (like the default user collection if configured), and if they want to create a login using one of such collections in that organization the API will fail because the token wasn't refresh. With this fix, the API succeeds.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

…sync org keys notification type is received before syncing in case claims change in the meantime like the user being invited and confirmed to a new orgaganization.
@fedemkr fedemkr requested review from a team and matt-livefront as code owners October 3, 2025 15:09
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2025

Logo
Checkmarx One – Scan Summary & Detailsf6d90cfd-bf86-446b-baef-d27ae519d308

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Oct 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.31%. Comparing base (e64f7d5) to head (c926417).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2018   +/-   ##
=======================================
  Coverage   81.31%   81.31%           
=======================================
  Files         831      832    +1     
  Lines       52430    52436    +6     
=======================================
+ Hits        42632    42638    +6     
  Misses       9798     9798           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fedemkr fedemkr merged commit f99774a into main Oct 3, 2025
10 checks passed
@fedemkr fedemkr deleted the PM-25992/refresh-token-on-org-push branch October 3, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants