Skip to content

Conversation

@mKoonrad
Copy link
Contributor

@mKoonrad mKoonrad commented Oct 6, 2025

🎟️ Tracking

#1880 (comment)

Should be Updating…

Last time someone unify all ... (3 dots) to character

📔 Objective

Standardize ellipsis character from ... (3 dots) to be used in other strings .

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@mKoonrad mKoonrad requested review from a team and matt-livefront as code owners October 6, 2025 14:30
@bitwarden-bot
Copy link

Thank you for your contribution! We've added this to our internal tracking system for review.
ID: PM-26543
Link: https://bitwarden.atlassian.net/browse/PM-26543

Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process.

@codecov
Copy link

codecov bot commented Oct 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.77%. Comparing base (277efe6) to head (4f686de).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2021      +/-   ##
==========================================
- Coverage   81.32%   75.77%   -5.56%     
==========================================
  Files         832     1020     +188     
  Lines       52457    62156    +9699     
==========================================
+ Hits        42663    47098    +4435     
- Misses       9794    15058    +5264     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@KatherineInCode KatherineInCode merged commit 365059d into bitwarden:main Oct 10, 2025
10 of 11 checks passed
@mKoonrad mKoonrad deleted the ellipsis-character branch October 10, 2025 13:57
kevinrossen pushed a commit to kevinrossen/bitwarden_ios that referenced this pull request Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants