generated from bitwarden/template
-
Notifications
You must be signed in to change notification settings - Fork 78
[PM-26064] Fix warnings with shared components #2038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2038 +/- ##
==========================================
- Coverage 85.28% 82.94% -2.34%
==========================================
Files 1690 1991 +301
Lines 144051 160985 +16934
==========================================
+ Hits 122851 133532 +10681
- Misses 21200 27453 +6253 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
matt-livefront
previously approved these changes
Oct 13, 2025
fedemkr
reviewed
Oct 14, 2025
BitwardenKit/UI/Platform/Application/Appearance/Modifiers/BitwardenMenuFooterTextModifier.swift
Outdated
Show resolved
Hide resolved
BitwardenKit/UI/Platform/Application/Appearance/Modifiers/ReviewModifier.swift
Outdated
Show resolved
Hide resolved
BitwardenKit/UI/Platform/Application/Views/BitwardenUITextView.swift
Outdated
Show resolved
Hide resolved
fedemkr
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-26064
📔 Objective
The various shared components in
BitwardenKithave a number of warnings. Some of these are documentation requirements now that they'republic; others are things like concurrency warnings that require strict concurrency mode to be on.This also migrates BWA to use the shared
UI.📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes