Skip to content

Conversation

@KatherineInCode
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-26064

📔 Objective

The various shared components in BitwardenKit have a number of warnings. Some of these are documentation requirements now that they're public; others are things like concurrency warnings that require strict concurrency mode to be on.

This also migrates BWA to use the shared UI.

📸 Screenshots

Before After
Simulator Screenshot - iPhone 17 Pro - 2025-10-13 at 13 52 56 Simulator Screenshot - iPhone 17 Pro - 2025-10-13 at 13 55 47

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@KatherineInCode KatherineInCode marked this pull request as ready for review October 13, 2025 20:46
@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2025

Logo
Checkmarx One – Scan Summary & Detailsd95bb072-c69d-4ef7-9e15-32d5e606829d

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Oct 13, 2025

Codecov Report

❌ Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.94%. Comparing base (7ccb499) to head (32144ad).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...Application/Views/FormFields/SliderFieldView.swift 0.00% 1 Missing ⚠️
TestHelpers/Support/BaseBitwardenTestCase.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2038      +/-   ##
==========================================
- Coverage   85.28%   82.94%   -2.34%     
==========================================
  Files        1690     1991     +301     
  Lines      144051   160985   +16934     
==========================================
+ Hits       122851   133532   +10681     
- Misses      21200    27453    +6253     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

matt-livefront
matt-livefront previously approved these changes Oct 13, 2025
@KatherineInCode KatherineInCode merged commit 39b11f1 into main Oct 15, 2025
12 checks passed
@KatherineInCode KatherineInCode deleted the pm-26064/tweaks branch October 15, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants