Skip to content

Conversation

@Hinton
Copy link
Member

@Hinton Hinton commented Sep 23, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-7587

📔 Objective

For development purposes it can be beneficial to build against a local SDK build instead of the published artifacts. This uses the include function of XcodeGen to conditionally swap out the remote dependency for a local if LOCAL_SDK env flag is set.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@codecov
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.74%. Comparing base (72cc8bd) to head (3473f2e).
Report is 20 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #960   +/-   ##
=======================================
  Coverage   88.74%   88.74%           
=======================================
  Files         638      638           
  Lines       39993    39993           
=======================================
  Hits        35491    35491           
  Misses       4502     4502           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 23, 2024

Logo
Checkmarx One – Scan Summary & Detailsd2f56315-4c4f-4bb3-a227-3c97dc700857

Fixed Issues

Severity Issue Source File / Package
MEDIUM Unpinned Actions Full Length Commit SHA /build.yml: 134

@Hinton Hinton changed the title Support conditionally loading local sdk [PM-7587] Support conditionally loading local sdk Sep 24, 2024
@Hinton Hinton requested a review from fedemkr September 24, 2024 09:16
@Hinton Hinton marked this pull request as ready for review September 24, 2024 09:16
fedemkr
fedemkr previously approved these changes Sep 24, 2024
Copy link
Member

@fedemkr fedemkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

fedemkr
fedemkr previously approved these changes Sep 26, 2024
@Hinton Hinton merged commit e646646 into main Oct 1, 2024
@Hinton Hinton deleted the ps/local-sdk-conditional branch October 1, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants