Skip to content

Conversation

@matt-livefront
Copy link
Collaborator

@matt-livefront matt-livefront commented Sep 24, 2024

🎟️ Tracking

PM-11217

📔 Objective

Updates the colors across the app to use the updated colors from the design style guide.

The biggest changes here include:

  • More semantic colors (primaryBitwarden has been replaced with iconSecondary, textInteraction, etc).
  • Swapped background colors. Previously backgroundSecondary was used as the background color for most views. This has been updated to be backgroundPrimary. And backgroundSecondary is primarily used as the cards and element background color.

There's still a few "Legacy" colors in the asset catalog which didn't have a direct mapping to the new style guide and will be removed/replaced in future PRs as components that use these colors are updated (e.g. loading screen, accessory buttons, etc).

📸 Screenshots

See snapshots.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Collaborator

@phil-livefront phil-livefront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsfbb0b6b7-73f5-4d37-a95f-84ef443032d1

No New Or Fixed Issues Found

@codecov
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 97.79412% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88.76%. Comparing base (a674339) to head (744a96c).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
.../UI/Auth/ProfileSwitcher/ProfileSwitcherItem.swift 0.00% 1 Missing ⚠️
...d/UI/Auth/ProfileSwitcher/ProfileSwitcherRow.swift 80.00% 1 Missing ⚠️
...pplication/Views/BitwardenMultilineTextField.swift 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #968   +/-   ##
=======================================
  Coverage   88.76%   88.76%           
=======================================
  Files         638      638           
  Lines       40082    40087    +5     
=======================================
+ Hits        35580    35585    +5     
  Misses       4502     4502           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matt-livefront matt-livefront merged commit ad3cf96 into main Sep 25, 2024
@matt-livefront matt-livefront deleted the matt/PM-11217-update-colors branch September 25, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants