[PM-10877] Use new version calculation in CI-main workflow #970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #970 +/- ##
=======================================
Coverage 89.10% 89.10%
=======================================
Files 657 657
Lines 41317 41317
=======================================
Hits 36814 36814
Misses 4503 4503 ☔ View full report in Codecov by Sentry. |
Contributor
|
New Issues
|
fedemkr
reviewed
Sep 26, 2024
This reverts commit 1e18762.
vvolkgang
force-pushed
the
ci-version-name
branch
from
7767edd to
a48819d
Compare
vvolkgang
force-pushed
the
ci-version-name
branch
14 times, most recently
from
d639159 to
7112430
Compare
vvolkgang
force-pushed
the
ci-version-name
branch
from
7112430 to
b67c219
Compare
# Conflicts: # .github/workflows/CI-main.yml
vvolkgang
commented
Oct 3, 2024
| build-version: ${{ needs.resolve-values.outputs.version_name }} | ||
| build-number: ${{ needs.resolve-values.outputs.version_number }} | ||
| xcode-version: ${{ needs.resolve-values.outputs.xcode_version }} | ||
| distribute: ${{ fromJSON(needs.resolve-values.outputs.distribute_to_testflight) }} |
Member
Author
There was a problem hiding this comment.
💡 outputs are always strings, fromJSON is converting it to a boolean
vvolkgang
commented
Oct 3, 2024
| build-number: ${{ needs.resolve-values.outputs.build_number }} | ||
| build-version: ${{ needs.resolve-values.outputs.version_name }} | ||
| build-number: ${{ needs.resolve-values.outputs.version_number }} | ||
| xcode-version: ${{ needs.resolve-values.outputs.xcode_version }} |
Member
Author
There was a problem hiding this comment.
for some reason ${{ env.*** }} isn't available here, we can access a bunch of other contexts, just not env. Seems like an oversight. We'll need to keep routing these through another job for the time being.
fedemkr
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-10877
📔 Objective
Implement the new version calculation in
CI-main.yml. Testing this brought the need to trigger builds without distributing them, added a new input to help managing that.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes