Skip to content

Conversation

@matt-livefront
Copy link
Collaborator

@matt-livefront matt-livefront commented Sep 30, 2024

🎟️ Tracking

PM-12976

📔 Objective

The two subscribesToBadgePublisher tests in SettingsProcessorsTests intermittently fail due to a threading issue with the shared featureFlagsBool dictionary in MockConfigService. To fix this, I opted to make MockConfigService run on the main actor. This seemed like the least invasive change to fix this given that most of our tests already run on the main actor.

Error: -[BitwardenSharedTests.SettingsProcessorTests test_init_subscribesToBadgePublisher_error] : -[_NSCoreDataTaggedObjectID objectForKey:]: unrecognized selector sent to instance 0x8000000000000000 (NSInvalidArgumentException)

https://github.com/bitwarden/ios/actions/runs/11076634320/job/30780148425#step:9:7762

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@codecov
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.80%. Comparing base (c20c8b3) to head (49f0072).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #987      +/-   ##
==========================================
+ Coverage   88.77%   88.80%   +0.02%     
==========================================
  Files         638      641       +3     
  Lines       40129    40213      +84     
==========================================
+ Hits        35625    35711      +86     
+ Misses       4504     4502       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details31a60b85-5810-42d3-8fd7-999331829b01

No New Or Fixed Issues Found

@matt-livefront matt-livefront merged commit 6a658ac into main Sep 30, 2024
8 checks passed
@matt-livefront matt-livefront deleted the matt/PM-12976-settings-tests branch September 30, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants