Skip to content

Conversation

@Hinton
Copy link
Member

@Hinton Hinton commented Sep 18, 2025

🎟️ Tracking

bitwarden.atlassian.net/browse/PM-25259

📔 Objective

Ignore Cargo.toml since it's handled by renovate. This resolves some blocking issues preventing API binding automation.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Hinton Hinton requested a review from a team as a code owner September 18, 2025 16:08
@Hinton Hinton requested a review from coroiu September 18, 2025 16:08
@Hinton Hinton changed the title Ignore Cargo.toml for api bindings [PM-25259] Ignore Cargo.toml for api bindings Sep 18, 2025
@Hinton Hinton merged commit 6552cdc into main Sep 18, 2025
44 checks passed
@Hinton Hinton deleted the api-cargo-ignore branch September 18, 2025 16:12
@sonarqubecloud
Copy link

@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details2e9678db-b079-4ae4-a333-6e99c2c573a0

Great job! No new security vulnerabilities introduced in this pull request

bw-ghapp bot pushed a commit to bitwarden/sdk-swift that referenced this pull request Sep 18, 2025
@codecov
Copy link

codecov bot commented Sep 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.26%. Comparing base (9272018) to head (a83eef6).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #461   +/-   ##
=======================================
  Coverage   78.26%   78.26%           
=======================================
  Files         275      275           
  Lines       27441    27441           
=======================================
  Hits        21476    21476           
  Misses       5965     5965           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants