Skip to content

Conversation

@Hinton
Copy link
Member

@Hinton Hinton commented Sep 19, 2025

🎟️ Tracking

📔 Objective

I noticed we missed updating a few places to use FolderId instead of str or uuid.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Hinton Hinton requested review from a team as code owners September 19, 2025 11:57
@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details2a776b5e-534f-41e3-9b8b-c4ff53e54261

Great job! No new security vulnerabilities introduced in this pull request

@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Sep 19, 2025

Codecov Report

❌ Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.25%. Comparing base (e30f1ea) to head (f044334).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/bitwarden-vault/src/folder/folder_client.rs 0.00% 2 Missing ⚠️
crates/bitwarden-vault/src/folder/get_list.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #464      +/-   ##
==========================================
- Coverage   78.25%   78.25%   -0.01%     
==========================================
  Files         275      275              
  Lines       27447    27444       -3     
==========================================
- Hits        21479    21476       -3     
  Misses       5968     5968              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@coroiu
Copy link
Contributor

coroiu commented Sep 22, 2025

@Hinton will this affect/break clients?

@Hinton
Copy link
Member Author

Hinton commented Sep 22, 2025

@Hinton will this affect/break clients?

No, this is still unused logic.

@Hinton Hinton merged commit 4603bef into main Sep 22, 2025
50 checks passed
@Hinton Hinton deleted the arch/folder-id branch September 22, 2025 14:12
bw-ghapp bot pushed a commit to bitwarden/sdk-swift that referenced this pull request Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants