Acknowledge bot review comment was incorrect - no Clone needed #548
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed review feedback on #547 regarding
GenericSessionRepositorycloneability. The bot incorrectly suggested adding#[derive(Clone)], but this is unnecessary.Context
IpcClient::startandIpcClient::handle_rpc_requesttakeself: &Arc<Self>, not&self:Since only the
Arcwrapper is cloned,GenericSessionRepositorydoesn't need to implementClone. No code changes required - current implementation is correct.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.