Skip to content

Conversation

Copy link

Copilot AI commented Nov 6, 2025

Addressed review feedback on #547 regarding GenericSessionRepository cloneability. The bot incorrectly suggested adding #[derive(Clone)], but this is unnecessary.

Context

IpcClient::start and IpcClient::handle_rpc_request take self: &Arc<Self>, not &self:

pub async fn start(self: &Arc<Self>) {
    // ...
    let client = self.clone();  // Clones the Arc, not IpcClient
}

Since only the Arc wrapper is cloned, GenericSessionRepository doesn't need to implement Clone. No code changes required - current implementation is correct.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI changed the title [WIP] Update JsIpcClient cloneability in session storage implementation Acknowledge bot review comment was incorrect - no Clone needed Nov 6, 2025
Copilot finished work on behalf of coroiu November 6, 2025 09:32
Copilot AI requested a review from coroiu November 6, 2025 09:32
@coroiu
Copy link
Contributor

coroiu commented Nov 6, 2025

Didn't even close it :)

@coroiu coroiu closed this Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants