Skip to content

Conversation

@Hinton
Copy link
Member

@Hinton Hinton commented Dec 20, 2024

🎟️ Tracking

📔 Objective

Adds a VERSION file to wasm artifacts with the full git hash to the commit used to build the artifact.

Resolves #12

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Hinton Hinton requested a review from coroiu December 20, 2024 15:03
@Hinton Hinton changed the title Add a file that prints the version on wasm build Add VERSION file to wasm-internal Dec 20, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Dec 20, 2024

Logo
Checkmarx One – Scan Summary & Details78100687-d202-428a-bec4-b83bba88adaa

No New Or Fixed Issues Found

Copy link
Contributor

@coroiu coroiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also do this using build.rs, but this works too 👍

@Hinton Hinton merged commit 42e7f45 into main Dec 20, 2024
33 checks passed
@Hinton Hinton deleted the add-version-file branch December 20, 2024 15:39
@codecov
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.27%. Comparing base (2fbc5ba) to head (ff869b7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #92   +/-   ##
=======================================
  Coverage   65.27%   65.27%           
=======================================
  Files         180      180           
  Lines       13833    13833           
=======================================
  Hits         9029     9029           
  Misses       4804     4804           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No Git tag associated with released versions

2 participants