Skip to content

Conversation

@Radical-Egg
Copy link
Contributor

🎟️ Tracking

Hi again,

This PR goes along with #111

📔 Objective

It would be helpful if an environment variable could be set to override the current default path for CA certificates. This would allow us to set BITWARDEN_APP_CACERTS to a common location like /etc/pki/tls/ca-bundle.crt or /etc/ssl/certs/ca-certificates.crt instead of a manual copy/symlink of CA certs to $SPLUNK_HOME/etc/auth/bitwarden_event_logs_cacerts.pem. With or without this change, it would also be helpful to document where to put custom CA certificates in the initial setup instructions or a debug statement in the logs to set the environment variable and/or check the default path $SPLUNK_HOME/etc/auth/bitwarden_event_logs_cacerts.pem.

Thanks for taking a look, I appreciate it!

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Radical-Egg Radical-Egg requested a review from a team as a code owner September 24, 2025 03:45
@Radical-Egg Radical-Egg requested a review from r-tome September 24, 2025 03:45
@eliykat eliykat requested review from eliykat and removed request for r-tome September 24, 2025 21:43
Copy link
Member

@eliykat eliykat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, this makes sense to me. It was also an issue I ran into when setting up a local server.

Once this is merged I'll let our docs team know.

@Radical-Egg Radical-Egg force-pushed the add-bitwarden-cacert-override branch from a7dd649 to d53c570 Compare September 26, 2025 17:58
@Radical-Egg Radical-Egg force-pushed the add-bitwarden-cacert-override branch from d53c570 to 16a9706 Compare September 26, 2025 18:02
@Radical-Egg Radical-Egg requested a review from eliykat September 26, 2025 18:13
@vincentsalucci
Copy link
Member

Internal tracking: PM-26199

@CLAassistant
Copy link

CLAassistant commented Sep 30, 2025

CLA assistant check
All committers have signed the CLA.

@bitwarden bitwarden deleted a comment from CLAassistant Sep 30, 2025
@github-actions
Copy link

Logo
Checkmarx One – Scan Summary & Detailse0911dce-3bf6-44d8-8825-17800fe37b22

Great job! No new security vulnerabilities introduced in this pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for custom CA path in _get_custom_ca_certificate_location function

4 participants