Skip to content

Conversation

jacksonConrad
Copy link
Contributor

blocks.go:

  • adds helper functions that proxy the flowkit Services.Blocks API
  • GetLatestBlock(), GetBlockAtHeight(), GetBlockById()
    blocks_test.go: happy paths for each added function

blocks.go:
  - adds helper functions that proxy the flowkit Services.Blocks API
  - GetLatestBlock(), GetBlockAtHeight(), GetBlockById()
blocks_test.go: happy paths for each added function
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2111673718

  • 12 of 12 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 59.175%

Totals Coverage Status
Change from base Build 2110376092: 0.3%
Covered Lines: 932
Relevant Lines: 1575

💛 - Coveralls

@jacksonConrad
Copy link
Contributor Author

@bjartek i added tests, though I'm not sure how necessary they are considering we are just proxying the flowkit Services.Blocks API.

I kept the helper functions simple. I figure if someone needs more, they can just use the overflow.Services APIs directly.

@bjartek bjartek merged commit bd831f3 into bjartek:main Apr 7, 2022
@bjartek
Copy link
Owner

bjartek commented Apr 7, 2022

Thanks! Merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants