Skip to content

Union preferredCountries with onlyCountries instead of concat for search #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 2, 2022
Merged

Union preferredCountries with onlyCountries instead of concat for search #492

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,7 +485,7 @@ class PhoneInput extends React.Component {
e.preventDefault();
if (!this.state.showDropdown && this.props.disabled) return;
const { preferredCountries, selectedCountry } = this.state
const allCountries = preferredCountries.concat(this.state.onlyCountries)
const allCountries = [...new Set(preferredCountries.concat(this.state.onlyCountries))];

const highlightCountryIndex = allCountries.findIndex(o =>
o.dialCode === selectedCountry.dialCode && o.iso2 === selectedCountry.iso2);
Expand Down Expand Up @@ -763,7 +763,7 @@ class PhoneInput extends React.Component {
getSearchFilteredCountries = () => {
const { preferredCountries, onlyCountries, searchValue } = this.state
const { enableSearch } = this.props
const allCountries = preferredCountries.concat(onlyCountries);
const allCountries = [...new Set(preferredCountries.concat(onlyCountries))];
const sanitizedSearchValue = searchValue.trim().toLowerCase();
if (enableSearch && sanitizedSearchValue) {
// [...new Set()] to get rid of duplicates
Expand Down