Skip to content

Conversation

@yerke
Copy link
Contributor

@yerke yerke commented Jun 5, 2021

Fix documentation by explicitly dropping connection

Everywhere in code we use drop(conn);. I guess docs were left out when this change happened.

Without this rustc will complain:

  --> tests/health_check.rs:52:5
   |
52 |     conn;
   |     ^^^^^ help: use `drop` to clarify the intent: `drop(conn);`
   |
   = note: `#[warn(path_statements)]` on by default

@yerke
Copy link
Contributor Author

yerke commented Jun 5, 2021

I see that TestMariaDb v101 CI job already fails on master branch.

@blackbeam
Copy link
Owner

Hi. Thanks for PR.
CI failure is unrelated and will be fixed in #154, so I'm merging this.

@blackbeam blackbeam merged commit 5bb9cb0 into blackbeam:master Jun 5, 2021
@yerke yerke deleted the drop-conn branch June 6, 2021 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants