Skip to content

style: break the loops when we can. #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
XenoAmess wants to merge 1 commit into from
Closed

style: break the loops when we can. #298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...st/java/com/synopsys/integration/detectable/detectables/yarn/unit/YarnLockParserTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,7 @@ void assertEntry(final YarnLock yarnLock, final String idName, final String idVe
for (final YarnLockDependency entryDependency : entry.getDependencies()) {
if (entryDependency.getName().equals(dependency.getName()) && entryDependency.getVersion().equals(dependency.getVersion()) && entryDependency.isOptional() == dependency.isOptional()) {
dFound = true;
break;
}
}
assertTrue(dFound, "Could not find yarn dependency for entry " + idName + " with name " + dependency.getName() + " and version " + dependency.getVersion() + " and optional " + dependency.isOptional() + ".");
Expand Down
2 changes: 2 additions & 0 deletions detector/src/main/java/com/synopsys/integration/detector/rule/DetectorRuleSetBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,7 @@ private boolean fallbackSatisfied(final DetectorRule rule, final List<DetectorRu
//When the Key detector fails we fallback to the Value detector. Therefore for a given rule, every time it is a Value that corresponding Key detector must have already been added.
if (rule.equals(fallback.getValue()) && !orderedRules.contains(fallback.getKey())) {
fallbackSatisfied = false;
break;
}
}
return fallbackSatisfied;
Expand All @@ -129,6 +130,7 @@ private boolean yieldSatisfied(final DetectorRule rule, final List<DetectorRule>
for (final DetectorRule yield : yieldsToRules.get(rule)) {
if (!orderedRules.contains(yield)) {
yieldedSatisfied = false;
break;
}
}
return yieldedSatisfied;
Expand Down