Skip to content

Add Badge for file size#44

Closed
webcaetano wants to merge 2 commits intoplurals:masterfrom
webcaetano:patch-1
Closed

Add Badge for file size#44
webcaetano wants to merge 2 commits intoplurals:masterfrom
webcaetano:patch-1

Conversation

@webcaetano
Copy link
Copy Markdown
Contributor

No description provided.

@coveralls
Copy link
Copy Markdown

coveralls commented Jul 15, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 7756b2d on webcaetano:patch-1 into 90d82f8 on blakeembrey:master.

@blakeembrey
Copy link
Copy Markdown
Collaborator

I like the idea, but is there a pointer to the algorithm used for this? Is there any uptime guarantees on the service also?

@webcaetano
Copy link
Copy Markdown
Contributor Author

@blakeembrey The information is generated live.
The server used for this is heroku. Many apps uses heroku (e.g. bower).
Never had a problem(offline, etc..) using this badge on my open-source projects.

More information behind it here: https://github.com/ngryman/badge-size

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling a792901 on webcaetano:patch-1 into 90d82f8 on blakeembrey:master.

@blakeembrey
Copy link
Copy Markdown
Collaborator

I love the idea, but, unfortunately, I don't think I can accept the PR even though I'd love to have something like this. My main issue is that there's no control over your service and it may go offline (intentionally or not) at any time. Do you think there's any way to get it onto shields.io?

@webcaetano webcaetano closed this Jul 18, 2016
@webcaetano webcaetano deleted the patch-1 branch July 18, 2016 01:58
@webcaetano
Copy link
Copy Markdown
Contributor Author

We are talking about heroku server.
Same server bower use.

https://status.heroku.com/

@webcaetano
Copy link
Copy Markdown
Contributor Author

Never saw shields.io go offline?

@blakeembrey
Copy link
Copy Markdown
Collaborator

It has before. I know Heroku, but it's your service. There's no guarantee you'll continue paying for it - assuming it is paid right now. If it's not, it has limited uptime. If it is, there's currently zero caching which would mean it can easy go offline if it's used somewhere you don't expect (right now all performance would be due to GitHub caching images).

@blakeembrey
Copy link
Copy Markdown
Collaborator

To be more useful to people, I think it'd be good to generate the bundled size (e.g. Browserified) over a single file which isn't representative of the full size.

@webcaetano
Copy link
Copy Markdown
Contributor Author

I got you point.

Its not my service. Its from an open-source project.
I also assume they use the free heroku plan.
With its not by time limit. But for usage.

The idea of kinda bagde its good.
It just need to be more solid.
I will think in a way to pass that over an shields.io badge.

@webcaetano
Copy link
Copy Markdown
Contributor Author

badges/shields#730

@blakeembrey
Copy link
Copy Markdown
Collaborator

Good to know, thanks! 👍

@webcaetano webcaetano mentioned this pull request Jul 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants