Skip to content

fix sink extraction issues fixes #498#509

Merged
BlayTheNinth merged 1 commit into
TwelveIterations:1.16.xfrom
Darkere:1.16.x
Mar 13, 2021
Merged

fix sink extraction issues fixes #498#509
BlayTheNinth merged 1 commit into
TwelveIterations:1.16.xfrom
Darkere:1.16.x

Conversation

@Darkere
Copy link
Copy Markdown
Contributor

@Darkere Darkere commented Mar 10, 2021

We keep getting reports with people extracting water instead of the request fluid through RS, so I figured a PR might speed up fixing this? ;)

This fixes the issue without changing what I think was the intended behavior.

If Sink requires water is set to true:

  • Sink behaves like a simple tank

If Sink requires water is set to false:

  • any fluid inserted will be voided
  • extraction provides water or nothing* if a different fluid is requested

*unless the config was changed and a fluid was inserted before that

@BlayTheNinth BlayTheNinth merged commit 96a61eb into TwelveIterations:1.16.x Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants