add Concurrency flag to fasthttp server #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Fair point, the default concurrency in FH is too high... maybe you can also set the default to be something like 512-1024 instead of zero (== 256k)? |
Author
|
Sure, let's use a more reasonable default. FWIW I've set this to 50 for my workload (starts OOMing around 70 with my benchmarks), with 10K samples/push request. |
added 2 commits
June 22, 2021 09:50
Owner
|
Thanks, LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are seeing the proxy crash due to OOM errors when there is a surge in requests. Pass through a
Concurrencyflag tofasthttpserver options to shed load (503s) when server is overloaded. When unset, thefasthttpdefault is256 * 1024.From
fasthttpdocs, the flag is defined as: