-
Notifications
You must be signed in to change notification settings - Fork 6
feat: Add dev mode in dingo #812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Akhil Repala <arepala@blinklabs.io>
…d line as well as from cofnig file Signed-off-by: Akhil Repala <arepala@blinklabs.io>
|
Tested all the cases like
|
…sableOutbound. Signed-off-by: Akhil Repala <arepala@blinklabs.io>
| network: "preview" | ||
| ` | ||
| tmpFile := "test-dev-mode.yaml" | ||
| err := os.WriteFile(tmpFile, []byte(yamlContent), 0644) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use a temp directory for this test file. This avoids the possibility of accidentally overwriting/removing a file that already exists.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made the changes and please review it.
… t.TempDir Signed-off-by: Akhil Repala <arepala@blinklabs.io>
Closes #808