feat: Make ledger historical validation threshold configurable #836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Akhil Repala <arepala@blinklabs.io>
wolf31o2
previously requested changes
Aug 11, 2025
| "fmt" | ||
| "io" | ||
| "log/slog" | ||
| "time" |
Member
There was a problem hiding this comment.
Rather than use time, we should use blocks.
This is part of the CardanoNodeConfig genesis configs. We can skip Byron, since we'll never be in Byron and it be recent. In the ShelleyGenesis() return, you can get SecurityParam from the gouroboros ledger shelley.ShelleyGenesis object, which is an int (though it actually has to be positive...)
We load this similarly to epoch length.
Contributor
There was a problem hiding this comment.
We can make this change in a follow-up ticket
agaffney
approved these changes
Aug 14, 2025
agaffney
dismissed
wolf31o2’s stale review
We can make this change in a follow-up ticket
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #672