Manage skills as sources over ACP by jamadeo · Pull Request #8675 · aaif-goose/goose

jamadeo · 2026-04-20T19:00:09Z

Introduces "sources", a generalization over skills/agents/projects. Uses sources CRUD to manage skills, removing the tauri command handlers.

Related Issue: #8686

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 828ef1908a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-04-20T19:09:06Z

+  const client = await getClient();
+  const raw = await client.extMethod("_goose/sources/list", { type: "skill" });


Preserve a mockable transport for skills API calls

Routing listSkills through getClient().extMethod(...) here bypasses the Tauri invoke("list_skills") path that our Playwright fixture still mocks in ui/goose2/tests/e2e/fixtures/tauri-mock.ts. In tauri-mocked runs, get_goose_serve_url is unhandled and resolves to null, so ACP initialization fails and SkillsView drops to an empty list, breaking the existing skills E2E flows that assert mocked skills are visible. Please add ACP mocking for these methods (or a test-mode fallback) before switching this call path.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-04-20T19:09:06Z

+    if env::var("GOOSE_SERVE_URL").is_ok() {
+        return Ok(env::var("GOOSE_SERVE_URL").unwrap());


Ignore blank GOOSE_SERVE_URL overrides

This override accepts any present GOOSE_SERVE_URL, including an empty string, and then skips launching the managed GooseServe process. If the variable is set but blank (a common CI/shell misconfiguration), the app returns an invalid websocket URL and ACP-dependent features fail instead of falling back to GooseServeProcess::get. Validate that the env var is non-empty (and preferably URL-shaped) before returning it.

Useful? React with 👍 / 👎.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 023342e8d9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-04-20T20:05:02Z

+        "version": 1,
+        "type": type_slug,
+        "name": name,
+        "description": description,
+        "content": content,


Preserve v1 skill field names in exported JSON

export_source still labels the payload as "version": 1 but now writes the skill body to "content" instead of the v1 "instructions" field, which causes silent data loss when the file is imported by clients that only understand the original v1 schema (they read an empty body). To keep cross-version .skill.json sharing safe, either emit the legacy instructions key (optionally alongside content) or bump the version and make older readers fail explicitly.

Useful? React with 👍 / 👎.

DOsinga

I have thoughts, but let's merge!

lifeizhou-ap · 2026-04-20T22:23:28Z

      const PERSONAS = ${personas};
      const SKILLS = ${skills};
      const PROJECTS = ${projects};
+      const FAKE_ACP_URL = "ws://127.0.0.1:0/mock-acp";


I feel we might not need e2e tests in the future. Basically we can mock the response in the unit test. and we can use the app e2e test to test the integration with acp server

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a3fb9b3199

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-04-20T22:26:17Z

+    if !raw.trim_start().starts_with("---") {
+        return (String::new(), raw.to_string());
+    }
+    match parse_frontmatter::<SkillFront>(raw) {


Handle --- inside skill frontmatter values

parse_skill_frontmatter delegates to parse_frontmatter, whose implementation in agents/platform_extensions/mod.rs splits the entire file on every ---. If a valid description contains --- (for example description: 'A --- B'), YAML parsing fails and this function falls back to (empty description, raw file); as a result list_sources/export_source can show blank descriptions and export frontmatter as content. The previous skills parser only looked for the closing frontmatter delimiter, so this is a regression for otherwise valid skill files.

Useful? React with 👍 / 👎.

* main: handle full node paths in goose2 kill recipe (#8709) overhaul provider inventory and agent/model selection (#8652) Remove unused import (#8676) delete the goose2 migration plan prompt (#8678) Add health score badge to README (#8677)

* main: feat(hooks): add Husky git hooks for ui/goose2 (#8577) fix: links in chat could not be opened (#8544) fix: run setup before dev and dev-debug in goose2 justfile (#8718) Manage skills as sources over ACP (#8675) handle full node paths in goose2 kill recipe (#8709) overhaul provider inventory and agent/model selection (#8652) Remove unused import (#8676) delete the goose2 migration plan prompt (#8678) Add health score badge to README (#8677) feat(goose2): voice dictation via direct-ACP pattern (#8609) consistently use actions-rust-lang/setup-rust-toolchain (#8671) fix(developer): run shell tool under bash/sh regardless of login shell (#8659) refactor(providers): extract shared OAuth device-flow helper (#8619) Add a goose2 release workflow (#8629) chore(deps): bump ncipollo/release-action from 1.20.0 to 1.21.0 (#8664) docs: add blog post about Mesh LLM provider option (#8655) fix: append /chat/completions for prefixed v1 base URLs (#8521) Reset ChatGPT Codex auth during OAuth setup (#8569) chore(deps): bump EmbarkStudios/cargo-deny-action from 2.0.15 to 2.0.17 (#8665) Add dependabot config for pnpm workspace, cargo, and actions (#8660)

Co-authored-by: Lifei Zhou <lifei@squareup.com>

jamadeo added 2 commits April 20, 2026 14:28

Manage skills as sources over ACP

60aa4ca

move to goose crate

828ef19

chatgpt-codex-connector Bot reviewed Apr 20, 2026

View reviewed changes

jamadeo added 7 commits April 20, 2026 15:09

clean up

748417f

fmt

29e5467

cleaner env

fb20c3e

more comment cleanup

496c64d

regenerate ACP types

16cb174

fix slicing

b45e01a

Merge remote-tracking branch 'origin/main' into jamadeo/sources-acp

023342e

chatgpt-codex-connector Bot reviewed Apr 20, 2026

View reviewed changes

alexhancock approved these changes Apr 20, 2026

View reviewed changes

DOsinga approved these changes Apr 20, 2026

View reviewed changes

jamadeo added 2 commits April 20, 2026 17:42

frontmatter parse

13fe482

Mock ACP calls

a3fb9b3

lifeizhou-ap reviewed Apr 20, 2026

View reviewed changes

chatgpt-codex-connector Bot reviewed Apr 20, 2026

View reviewed changes

lifeizhou-ap added 2 commits April 21, 2026 11:31

Merge branch 'main' into jamadeo/sources-acp

ee3c5dd

* main: handle full node paths in goose2 kill recipe (#8709) overhaul provider inventory and agent/model selection (#8652) Remove unused import (#8676) delete the goose2 migration plan prompt (#8678) Add health score badge to README (#8677)

regenerate ts

31edbb2

lifeizhou-ap added this pull request to the merge queue Apr 21, 2026

Merged via the queue into main with commit b1235e7 Apr 21, 2026
25 checks passed

lifeizhou-ap deleted the jamadeo/sources-acp branch April 21, 2026 03:17

alexhancock mentioned this pull request Apr 21, 2026

docs: AGENTS.md section on goose2 desktop backend architecture #8732

Merged

DOsinga mentioned this pull request Apr 21, 2026

feat: projects as backend sources with system prompt injection #8739

Open

spikewang pushed a commit to spikewang/goose that referenced this pull request Apr 22, 2026

Manage skills as sources over ACP (aaif-goose#8675)

a4dfd0a

Co-authored-by: Lifei Zhou <lifei@squareup.com>

github-actions Bot mentioned this pull request Apr 23, 2026

chore(release): release version 1.32.0 #8764

Closed

BrewTestBot mentioned this pull request Apr 23, 2026

block-goose-cli 1.32.0 Homebrew/homebrew-core#279029

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Manage skills as sources over ACP#8675

Manage skills as sources over ACP#8675
lifeizhou-ap merged 13 commits intomainfrom
jamadeo/sources-acp

jamadeo commented Apr 20, 2026 •

edited by lifeizhou-ap

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Apr 20, 2026

Uh oh!

chatgpt-codex-connector Bot Apr 20, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Apr 20, 2026

Uh oh!

DOsinga left a comment

Uh oh!

lifeizhou-ap Apr 20, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Apr 20, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		const client = await getClient();
		const raw = await client.extMethod("_goose/sources/list", { type: "skill" });

		if env::var("GOOSE_SERVE_URL").is_ok() {
		return Ok(env::var("GOOSE_SERVE_URL").unwrap());

Conversation

jamadeo commented Apr 20, 2026 • edited by lifeizhou-ap Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

DOsinga left a comment

Choose a reason for hiding this comment

Uh oh!

lifeizhou-ap Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jamadeo commented Apr 20, 2026 •

edited by lifeizhou-ap

Loading