Decided message signers fix #431
Conversation
amirylm
force-pushed
the
decided-fix
branch
3 times, most recently
from
d671b51 to
327e01c
Compare
| zap.String("identifier", string(netMsg.SignedMessage.Message.Lambda))) | ||
| if err := runningInstance.CommitMsgValidationPipeline().Run(netMsg.SignedMessage); err != nil { | ||
| zap.Uint64s("signers", netMsg.SignedMessage.SignerIds)) | ||
| if err := instance.CommitMsgValidationPipelineV0(identifier, seq, i.ValidatorShare).Run(netMsg.SignedMessage); err != nil { |
There was a problem hiding this comment.
@amir-blox better use the fork and not the implementation directly
| } | ||
|
|
||
| // CommitMsgValidationPipelineV0 is version 0 of commit message validation | ||
| func CommitMsgValidationPipelineV0(identifier []byte, seq uint64, share *storage.Share) pipeline.Pipeline { |
There was a problem hiding this comment.
that seems redundant ..
There was a problem hiding this comment.
its a function so the late commit (in controller level) and exporter could use it as well
There was a problem hiding this comment.
we have the instance which has that function why create another?
There was a problem hiding this comment.
late commit is done on controller level when the instance finished and on exporter, in both cases we don't have an instance..
|
The ibft instance is not available in late commit scenarios:
Therefore in this PR, a static commit message validation function was added to overcome the missing instance object. |
Resolve #430
IBFT messages were purged once the instance decided or stopped, the behavior changed in this PR: