Skip to content

Enable IBFT implementation init more than once #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
amirylm merged 17 commits into from
Nov 29, 2021
Merged

Enable IBFT implementation init more than once #445

amirylm merged 17 commits into from
Nov 29, 2021

Conversation

@amirylm
Copy link
Contributor

@amirylm amirylm commented Nov 22, 2021 •
edited
Loading

Resolve #436

  • separate network init from sync
  • enable to call validator.Start (calls IBFT init) multiple times to ensure validator is online and synced
  • trigger IBFT sync if initial sync failed:
    • on every incoming duty
    • upon decided message from validator's committee
  • fixed simulation tests and add test for sync failover

@amirylm amirylm force-pushed the ibft-init-fix branch 8 times, most recently from 880b5f9 to 6638409 Compare November 28, 2021 11:10
@amirylm amirylm force-pushed the ibft-init-fix branch 3 times, most recently from 2fe175e to c4b8204 Compare November 29, 2021 08:59
@amirylm
fix simulation runner and add test
7700fcb 
- missing implementation in mock signer
- switch to generated share key
- add test for sync failover
@amirylm amirylm marked this pull request as ready for review November 29, 2021 11:24
@amirylm amirylm merged commit add2e64 into stage Nov 29, 2021
@nivBlox nivBlox mentioned this pull request Nov 30, 2021
Merged
@amirylm amirylm deleted the ibft-init-fix branch December 13, 2021 12:16
@amirylm amirylm self-assigned this Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alonmuroch alonmuroch Awaiting requested review from alonmuroch

1 more reviewer

@nivBlox nivBlox nivBlox approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@amirylm amirylm

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@amirylm @nivBlox