Skip to content

Conversation

@matiwinnetou
Copy link
Contributor

@matiwinnetou matiwinnetou commented Mar 17, 2023

Apparently it is
mem = 14000000L

on main-net, not 16000000L

This raises interesting question if we should be keeping default or rather read default from Aiken... all defaults.

data source: https://cexplorer.io/params

@matiwinnetou matiwinnetou changed the title fix budgets Fix budgets Mar 17, 2023
@satran004
Copy link
Member

Thanks @matiwinnetou. Let's merge this for now.

We can add another method in Aiken JNA wrapper layer without InitialBudget and remove default from java code.

So, a Java app can use

  1. TxEvaluator() - This will use default initial budget config defined in Aiken. Need to check if Aiken also has a default SlotConfig?
  2. TxEvaluator(slotConfig, initialBudgetConfig) - Use application provided slotConfig and initialBudgetConfig

Issue

@satran004 satran004 merged commit ab8ea15 into bloxbean:main Mar 18, 2023
@matiwinnetou
Copy link
Contributor Author

Yes but I am not sure which one is the correct approach, relying on SlotConfig and InitialBudget from Aiken or managing this in java layer. Keep in mind that Aiken team will likely forget to keep this updated.

These params can be updated on main-net within one epoch and in addition when running devnets, on Hydra, these parameters can be vastly different than defaults.

IMHO, ideal approach would be to always read those params in an app (based on live settings + some cache) and always pass them down the invocation stack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants