Refactor package export #262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 784e6e7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
claytercek
force-pushed
the
fix/no-barrel
branch
from
4c3a25a to
ef6420e
Compare
Member
Author
|
Might hold on merging this for a later v3 release. |
Member
Author
|
Actually, after profiling, I'm finding this doesn't make a significant difference in terms of memory usage or startup speed. Module resolution is FAST. Gonna rework it so that there still are some barrel files, but only the common public API is included. |
After profiling, it turns out that removing barrel files really doesn't have a performance impact for this use. We're keeping the more specific import paths, but als adding back some barrels for convenience.
claytercek
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a major breaking change across all Launchpad packages: it removes all barrel (index) files, requiring imports to reference specific module paths directly. The change impacts import statements throughout the codebase and documentation, and enforces this new structure via linting. Additionally, documentation is updated to clarify usage for both monorepo and individual package installations.
Barrel File Removal and Import Path Updates
@bluecadet/launchpad-content/plugins/...and sources from@bluecadet/launchpad-content/sources/....Linting and Tooling
noBarrelFile) to enforce the absence of barrel files, and extended the Biome configuration to include this rule and to lint TypeScript files in thescriptsdirectory.Documentation Improvements
@bluecadet/launchpad), explaining how to adjust import paths accordingly.These changes are major and breaking, so all downstream code and documentation must update import paths to match the new structure.
Resolves #255