Skip to content

Conversation

@m-mcgowan
Copy link
Contributor

No description provided.

@m-mcgowan
Copy link
Contributor Author

As well as this PR, the settings in coveralls.io were changed:

  • coverage threshold for failure: 80%
  • coverage decrease threshold for failure: 0.1%

@m-mcgowan m-mcgowan marked this pull request as draft October 19, 2021 13:21
@m-mcgowan
Copy link
Contributor Author

The coverage difference is computed against the last two commits to this branch, which is not what we want.

The job ID seems a bit strange, which is indicated here as the cause - github.com/lemurheavy/coveralls-public/issues/1019. (Deliberately not putting the full url so we don't create a reference to this PR from that issue.)

Going to try to set the job ID from the Github CI environment.

@m-mcgowan
Copy link
Contributor Author

I like the github action better than our previous approach because it gets branch names and other details correct, although it doesn't appear check the PR against the master branch at present. (That may have something to do with the type of reporting used, so we'll check after merging this to master.)

@m-mcgowan m-mcgowan requested a review from zfields October 28, 2021 19:00
@m-mcgowan m-mcgowan self-assigned this Oct 28, 2021
@bsatrom
Copy link
Member

bsatrom commented Oct 28, 2021

If this is ready for review, I can give it a look.

@m-mcgowan m-mcgowan marked this pull request as ready for review November 2, 2021 10:56
@m-mcgowan
Copy link
Contributor Author

I think it's about as good as we can get it considering the uphill climb it's been to get this far. I'd like to merge it and gain some experience with how well it works and then make adjustments as necessary.

@m-mcgowan m-mcgowan requested a review from bsatrom November 2, 2021 10:58
@zfields
Copy link
Contributor

zfields commented Nov 2, 2021

I'll review it today.

@zfields
Copy link
Contributor

zfields commented Nov 3, 2021

I spent the better part of the day reviewing the PR and understanding the short-comings of the official Coveralls GitHub Action...

The official Coveralls GitHub Action does not distinguish between the Docker action file system, VM action file system and native GitHub runner file system.

By updating the file paths in the lcov file, I was able to eliminate a significant portion of our CI infrastructure and simplify the implementation. That research spike is captured in #67.

I propose closing this PR and adopting #67 instead.

Copy link
Contributor

@zfields zfields left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Propose migrating to alternate solution.

@zfields
Copy link
Contributor

zfields commented Nov 3, 2021

Closed in favor of #67

@zfields zfields closed this Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants