-
Notifications
You must be signed in to change notification settings - Fork 8
add code without coverage to verify that a decrease in coverage fails the build #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
As well as this PR, the settings in coveralls.io were changed:
|
|
The coverage difference is computed against the last two commits to this branch, which is not what we want. The job ID seems a bit strange, which is indicated here as the cause - github.com/lemurheavy/coveralls-public/issues/1019. (Deliberately not putting the full url so we don't create a reference to this PR from that issue.) Going to try to set the job ID from the Github CI environment. |
|
I like the github action better than our previous approach because it gets branch names and other details correct, although it doesn't appear check the PR against the master branch at present. (That may have something to do with the type of reporting used, so we'll check after merging this to master.) |
|
If this is ready for review, I can give it a look. |
|
I think it's about as good as we can get it considering the uphill climb it's been to get this far. I'd like to merge it and gain some experience with how well it works and then make adjustments as necessary. |
|
I'll review it today. |
|
I spent the better part of the day reviewing the PR and understanding the short-comings of the official Coveralls GitHub Action... The official Coveralls GitHub Action does not distinguish between the Docker action file system, VM action file system and native GitHub runner file system. By updating the file paths in the I propose closing this PR and adopting #67 instead. |
zfields
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Propose migrating to alternate solution.
|
Closed in favor of #67 |
No description provided.