add slurs to reserved words #1318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/identifier/src/reserved.ts
Outdated
| @@ -1047,10 +1047,61 @@ const famousAccounts = [ | |||
| 'zerohora', | |||
| ] | |||
|
|
|||
| // Needs additional work to add more words that should be cought and regex added to catch common variations | |||
There was a problem hiding this comment.
nice. glad this is open. just a typo in the comment. should be "caught" not "cought"
Separately, first time in here and im on my phone, TODOs okay in comment like this or should we open a separate issue to cover this?
There was a problem hiding this comment.
just saw the previous PR. probs not worth a change right now. disregard! ty!
There was a problem hiding this comment.
yeah TODOs in comments are totally fine
There was a problem hiding this comment.
hi, trying to figure out how this all works & hope it's okay to leave this here. i've appended the list with an additional set of 25-30 terms and variations, each of which i believe falls under the category of "absolutely bad and is never used in a reclaimed context." viewable here: https://gist.github.com/gay-frogs/aaa6ead819b62a3538d95b1ded6e571a
There was a problem hiding this comment.
additional set of 25-30 terms and variations, each of which i believe falls under the category of "absolutely bad and is never used in a reclaimed context." viewable here: https://gist.github.com/gay-frogs/aaa6ead819b62a3538d95b1ded6e571a
The term Yid is literally just the Yiddish word for Jew. It is used as a slur by non-Jews but it's routinely used by Jews, both Yiddish and English speakers, in its original context.
I believe there may be similar concerns with some of the other entries.
There was a problem hiding this comment.
additional set of 25-30 terms and variations, each of which i believe falls under the category of "absolutely bad and is never used in a reclaimed context." viewable here: https://gist.github.com/gay-frogs/aaa6ead819b62a3538d95b1ded6e571a
I believe there may be similar concerns with some of the other entries.
"Goyim" jumps out at me in that list because it's legitimately used neutrally by Jews to mean "non-Jews," especially when talking about antisemitism. It's used in Yiddish and in modern Hebrew with the same meaning.
There was a problem hiding this comment.
thanks for these. i was not fully aware of those definitions and appreciate you all for the corrections
Closed
dholms
added a commit
that referenced
this pull request
Jul 18, 2023
* add slurs to reserved words (#1314) * Update reserved.ts Add slurs to reserved words * Update reserved.ts fix typo * Update reserved.ts to clean up the slur list * linting * pluralise --------- Co-authored-by: jess <jesslarkdev+gh@gmail.com>
dholms
added a commit
that referenced
this pull request
Jul 19, 2023
* proxy timeline skeleton construction to appview * add getFeedSkeleton to appview * mount route * smart proxy feed skeletons * tests * proper error code * only proxy specific feeds * build branch * update proxyable feed logic, should use feed publisher rather than generator * fix feed proxy tests, configure feed publisher (in addition to generator) * hotfix: prevent user-supplied rkey on posts with createRecord (#1313) * prevent user-supplied rkey on posts with createRecord * allow empty-string rkey parameter Co-authored-by: devin ivy <devinivy@gmail.com> --------- Co-authored-by: devin ivy <devinivy@gmail.com> * add slurs to reserved words (#1318) * add slurs to reserved words (#1314) * Update reserved.ts Add slurs to reserved words * Update reserved.ts fix typo * Update reserved.ts to clean up the slur list * linting * pluralise --------- Co-authored-by: jess <jesslarkdev+gh@gmail.com> * identifier: tweaks and additions to slur list (#1319) * Refactor appview repo subscription for memleak (#1308) * refactor to remove closure in loop * move consecutive item out of p-queue * Handle validation improvements (#1336) * Handle matches and false positives for unacceptable words in handles * move handle validation logic to pds * missed merge * add cfg flag * encode lists * fix build issues * move words to cfg * tidy --------- Co-authored-by: Jaz Volpert <ericvolp12@gmail.com> * Allow moderators to take and reverse actor takedowns (#1330) allow moderators to take and reverse actor takedowns * ✨ Allow searching reports by moderator did (#1283) * ✨ Allow searching reports by moderator did * ✅ Remove .only flags on tests * ✅ Update snapshot * ✅ Add checks for did match in actions * v0.4.1 * Make sequencer leader behavior optional on pds (#1250) * make sequencer leader behavior optional on pds * tidy * use 127.0.0.1 in with-test-db.sh for colima (#1297) So, since Docker Desktop has licensing issues, some folks use colima for running containers on their macOS machines (The licensing exempted CLI-only version of Docker only exists on Linux). Unfortunately, colima binds host ports only on the IPv4 localhost address (`127.0.0.1`) while the atproto postgres clients will attempt to connect to the IPv6 localhost address (`::1`) that macOS sets in /etc/hosts. See abiosoft/colima#583 and lima-vm/lima#1330 for the tickets against colima. (Docker Desktop binds to both IPv4 and IPv6 localhost addresses and so doesn't have this issue.) To workaround this silly issue, we can use `localhost` within the docker containers and docker-compose, but need to set the `DB_POSTGRES_URL` env var to use the IPv4 localhost explicitly. (Asking folks to edit /etc/hosts causes other tools to break and will be overridden on each OS upgrade.) * Subscription util tests (#1295) * consecutive list tests * flesh out subscription util tests --------- Co-authored-by: Devin Ivy <devinivy@gmail.com> * Content reporting on record fields (#1351) * content reporting on record fields * fix test * tests * tidy * Check rkey contents just for non-tids (#1353) check rkey content for non-tids * ✨ Added new procedure for sending admin email (#1312) * 🚧 Added new lexicon for sending admin email * ✨ Add moderation mailer * ✨ Switch to text email content from html * 🧹 Cleanup some early implementation code and reflect PR reivew * ✨ Use smtp host instead of gmail service config * ✨ Move to using single smtp url * v0.4.2 * Patch up a couple sqlite tests (#1355) patch up a couple sqlite tests * enable feeds & build branch * disable branch building & enable without proxy header --------- Co-authored-by: Devin Ivy <devinivy@gmail.com> Co-authored-by: David Buchanan <d@vidbuchanan.co.uk> Co-authored-by: jess <jesslarkdev+gh@gmail.com> Co-authored-by: bnewbold <bnewbold@robocracy.org> Co-authored-by: Jaz Volpert <ericvolp12@gmail.com> Co-authored-by: Foysal Ahamed <cfaion341@gmail.com> Co-authored-by: Jeff Hodges <jeff@somethingsimilar.com>
dholms
added a commit
that referenced
this pull request
Jul 24, 2023
* proxy timeline skeleton construction to appview * add getFeedSkeleton to appview * mount route * smart proxy feed skeletons * tests * proper error code * only proxy specific feeds * build branch * update proxyable feed logic, should use feed publisher rather than generator * fix feed proxy tests, configure feed publisher (in addition to generator) * hotfix: prevent user-supplied rkey on posts with createRecord (#1313) * prevent user-supplied rkey on posts with createRecord * allow empty-string rkey parameter Co-authored-by: devin ivy <devinivy@gmail.com> --------- Co-authored-by: devin ivy <devinivy@gmail.com> * add slurs to reserved words (#1318) * add slurs to reserved words (#1314) * Update reserved.ts Add slurs to reserved words * Update reserved.ts fix typo * Update reserved.ts to clean up the slur list * linting * pluralise --------- Co-authored-by: jess <jesslarkdev+gh@gmail.com> * identifier: tweaks and additions to slur list (#1319) * Refactor appview repo subscription for memleak (#1308) * refactor to remove closure in loop * move consecutive item out of p-queue * Handle validation improvements (#1336) * Handle matches and false positives for unacceptable words in handles * move handle validation logic to pds * missed merge * add cfg flag * encode lists * fix build issues * move words to cfg * tidy --------- Co-authored-by: Jaz Volpert <ericvolp12@gmail.com> * Allow moderators to take and reverse actor takedowns (#1330) allow moderators to take and reverse actor takedowns * ✨ Allow searching reports by moderator did (#1283) * ✨ Allow searching reports by moderator did * ✅ Remove .only flags on tests * ✅ Update snapshot * ✅ Add checks for did match in actions * v0.4.1 * Make sequencer leader behavior optional on pds (#1250) * make sequencer leader behavior optional on pds * tidy * use 127.0.0.1 in with-test-db.sh for colima (#1297) So, since Docker Desktop has licensing issues, some folks use colima for running containers on their macOS machines (The licensing exempted CLI-only version of Docker only exists on Linux). Unfortunately, colima binds host ports only on the IPv4 localhost address (`127.0.0.1`) while the atproto postgres clients will attempt to connect to the IPv6 localhost address (`::1`) that macOS sets in /etc/hosts. See abiosoft/colima#583 and lima-vm/lima#1330 for the tickets against colima. (Docker Desktop binds to both IPv4 and IPv6 localhost addresses and so doesn't have this issue.) To workaround this silly issue, we can use `localhost` within the docker containers and docker-compose, but need to set the `DB_POSTGRES_URL` env var to use the IPv4 localhost explicitly. (Asking folks to edit /etc/hosts causes other tools to break and will be overridden on each OS upgrade.) * Subscription util tests (#1295) * consecutive list tests * flesh out subscription util tests --------- Co-authored-by: Devin Ivy <devinivy@gmail.com> * Content reporting on record fields (#1351) * content reporting on record fields * fix test * tests * tidy * Check rkey contents just for non-tids (#1353) check rkey content for non-tids * ✨ Added new procedure for sending admin email (#1312) * 🚧 Added new lexicon for sending admin email * ✨ Add moderation mailer * ✨ Switch to text email content from html * 🧹 Cleanup some early implementation code and reflect PR reivew * ✨ Use smtp host instead of gmail service config * ✨ Move to using single smtp url * v0.4.2 * Patch up a couple sqlite tests (#1355) patch up a couple sqlite tests * enable feeds & build branch * disable branch building & enable without proxy header --------- Co-authored-by: Devin Ivy <devinivy@gmail.com> Co-authored-by: David Buchanan <d@vidbuchanan.co.uk> Co-authored-by: jess <jesslarkdev+gh@gmail.com> Co-authored-by: bnewbold <bnewbold@robocracy.org> Co-authored-by: Jaz Volpert <ericvolp12@gmail.com> Co-authored-by: Foysal Ahamed <cfaion341@gmail.com> Co-authored-by: Jeff Hodges <jeff@somethingsimilar.com>
dholms
added a commit
that referenced
this pull request
Jul 24, 2023
* refactor appview services * tidy types * Allow moderators to take and reverse actor takedowns (#1330) allow moderators to take and reverse actor takedowns * ✨ Allow searching reports by moderator did (#1283) * ✨ Allow searching reports by moderator did * ✅ Remove .only flags on tests * ✅ Update snapshot * ✅ Add checks for did match in actions * v0.4.1 * Make sequencer leader behavior optional on pds (#1250) * make sequencer leader behavior optional on pds * tidy * use 127.0.0.1 in with-test-db.sh for colima (#1297) So, since Docker Desktop has licensing issues, some folks use colima for running containers on their macOS machines (The licensing exempted CLI-only version of Docker only exists on Linux). Unfortunately, colima binds host ports only on the IPv4 localhost address (`127.0.0.1`) while the atproto postgres clients will attempt to connect to the IPv6 localhost address (`::1`) that macOS sets in /etc/hosts. See abiosoft/colima#583 and lima-vm/lima#1330 for the tickets against colima. (Docker Desktop binds to both IPv4 and IPv6 localhost addresses and so doesn't have this issue.) To workaround this silly issue, we can use `localhost` within the docker containers and docker-compose, but need to set the `DB_POSTGRES_URL` env var to use the IPv4 localhost explicitly. (Asking folks to edit /etc/hosts causes other tools to break and will be overridden on each OS upgrade.) * Subscription util tests (#1295) * consecutive list tests * flesh out subscription util tests --------- Co-authored-by: Devin Ivy <devinivy@gmail.com> * Content reporting on record fields (#1351) * content reporting on record fields * fix test * tests * tidy * Check rkey contents just for non-tids (#1353) check rkey content for non-tids * ✨ Added new procedure for sending admin email (#1312) * 🚧 Added new lexicon for sending admin email * ✨ Add moderation mailer * ✨ Switch to text email content from html * 🧹 Cleanup some early implementation code and reflect PR reivew * ✨ Use smtp host instead of gmail service config * ✨ Move to using single smtp url * v0.4.2 * Patch up a couple sqlite tests (#1355) patch up a couple sqlite tests * Increase appview keepalive (#1360) increase keepalive to 90s * Appview - serve feed skeletons (#1265) * proxy timeline skeleton construction to appview * add getFeedSkeleton to appview * mount route * smart proxy feed skeletons * tests * proper error code * only proxy specific feeds * build branch * update proxyable feed logic, should use feed publisher rather than generator * fix feed proxy tests, configure feed publisher (in addition to generator) * hotfix: prevent user-supplied rkey on posts with createRecord (#1313) * prevent user-supplied rkey on posts with createRecord * allow empty-string rkey parameter Co-authored-by: devin ivy <devinivy@gmail.com> --------- Co-authored-by: devin ivy <devinivy@gmail.com> * add slurs to reserved words (#1318) * add slurs to reserved words (#1314) * Update reserved.ts Add slurs to reserved words * Update reserved.ts fix typo * Update reserved.ts to clean up the slur list * linting * pluralise --------- Co-authored-by: jess <jesslarkdev+gh@gmail.com> * identifier: tweaks and additions to slur list (#1319) * Refactor appview repo subscription for memleak (#1308) * refactor to remove closure in loop * move consecutive item out of p-queue * Handle validation improvements (#1336) * Handle matches and false positives for unacceptable words in handles * move handle validation logic to pds * missed merge * add cfg flag * encode lists * fix build issues * move words to cfg * tidy --------- Co-authored-by: Jaz Volpert <ericvolp12@gmail.com> * Allow moderators to take and reverse actor takedowns (#1330) allow moderators to take and reverse actor takedowns * ✨ Allow searching reports by moderator did (#1283) * ✨ Allow searching reports by moderator did * ✅ Remove .only flags on tests * ✅ Update snapshot * ✅ Add checks for did match in actions * v0.4.1 * Make sequencer leader behavior optional on pds (#1250) * make sequencer leader behavior optional on pds * tidy * use 127.0.0.1 in with-test-db.sh for colima (#1297) So, since Docker Desktop has licensing issues, some folks use colima for running containers on their macOS machines (The licensing exempted CLI-only version of Docker only exists on Linux). Unfortunately, colima binds host ports only on the IPv4 localhost address (`127.0.0.1`) while the atproto postgres clients will attempt to connect to the IPv6 localhost address (`::1`) that macOS sets in /etc/hosts. See abiosoft/colima#583 and lima-vm/lima#1330 for the tickets against colima. (Docker Desktop binds to both IPv4 and IPv6 localhost addresses and so doesn't have this issue.) To workaround this silly issue, we can use `localhost` within the docker containers and docker-compose, but need to set the `DB_POSTGRES_URL` env var to use the IPv4 localhost explicitly. (Asking folks to edit /etc/hosts causes other tools to break and will be overridden on each OS upgrade.) * Subscription util tests (#1295) * consecutive list tests * flesh out subscription util tests --------- Co-authored-by: Devin Ivy <devinivy@gmail.com> * Content reporting on record fields (#1351) * content reporting on record fields * fix test * tests * tidy * Check rkey contents just for non-tids (#1353) check rkey content for non-tids * ✨ Added new procedure for sending admin email (#1312) * 🚧 Added new lexicon for sending admin email * ✨ Add moderation mailer * ✨ Switch to text email content from html * 🧹 Cleanup some early implementation code and reflect PR reivew * ✨ Use smtp host instead of gmail service config * ✨ Move to using single smtp url * v0.4.2 * Patch up a couple sqlite tests (#1355) patch up a couple sqlite tests * enable feeds & build branch * disable branch building & enable without proxy header --------- Co-authored-by: Devin Ivy <devinivy@gmail.com> Co-authored-by: David Buchanan <d@vidbuchanan.co.uk> Co-authored-by: jess <jesslarkdev+gh@gmail.com> Co-authored-by: bnewbold <bnewbold@robocracy.org> Co-authored-by: Jaz Volpert <ericvolp12@gmail.com> Co-authored-by: Foysal Ahamed <cfaion341@gmail.com> Co-authored-by: Jeff Hodges <jeff@somethingsimilar.com> * add optional ilike query to getPopularFeedGenerators * fix lint * fix lint * handle sqlite too in pds only * fix lint * v0.4.3 * Include takendown posts for admins (feature branch) (#1361) * 🚧 WIP including takendown posts on author feed * ✨ Add takedown id on posts when including taken down posts * 🧹 Cleanup the auth verifier and other bsky package code * ✅ Add test for admin getAuthorFeed * 🧹 Cleanup lexicon and exclude takedownId * more explicit plumbing for post hydration w/o requester or with takedown info * pass along flag for soft-deleted actors * cleanup getAuthorFeed w/ auth * reorg getAuthorFeed logic around role/access-based auth --------- Co-authored-by: Foysal Ahamed <cfaion341@gmail.com> * ✨ Disable signing up with invite code from takendown account (#1350) * fix viewer data --------- Co-authored-by: Devin Ivy <devinivy@gmail.com> Co-authored-by: Foysal Ahamed <cfaion341@gmail.com> Co-authored-by: Jeff Hodges <jeff@somethingsimilar.com> Co-authored-by: David Buchanan <d@vidbuchanan.co.uk> Co-authored-by: jess <jesslarkdev+gh@gmail.com> Co-authored-by: bnewbold <bnewbold@robocracy.org> Co-authored-by: Jaz Volpert <ericvolp12@gmail.com> Co-authored-by: Eric Bailey <git@esb.lol>
mloar
pushed a commit
to mloar/atproto
that referenced
this pull request
Sep 26, 2023
* add slurs to reserved words (bluesky-social#1314) * Update reserved.ts Add slurs to reserved words * Update reserved.ts fix typo * Update reserved.ts to clean up the slur list * linting * pluralise --------- Co-authored-by: jess <jesslarkdev+gh@gmail.com>
mloar
pushed a commit
to mloar/atproto
that referenced
this pull request
Sep 26, 2023
* proxy timeline skeleton construction to appview * add getFeedSkeleton to appview * mount route * smart proxy feed skeletons * tests * proper error code * only proxy specific feeds * build branch * update proxyable feed logic, should use feed publisher rather than generator * fix feed proxy tests, configure feed publisher (in addition to generator) * hotfix: prevent user-supplied rkey on posts with createRecord (bluesky-social#1313) * prevent user-supplied rkey on posts with createRecord * allow empty-string rkey parameter Co-authored-by: devin ivy <devinivy@gmail.com> --------- Co-authored-by: devin ivy <devinivy@gmail.com> * add slurs to reserved words (bluesky-social#1318) * add slurs to reserved words (bluesky-social#1314) * Update reserved.ts Add slurs to reserved words * Update reserved.ts fix typo * Update reserved.ts to clean up the slur list * linting * pluralise --------- Co-authored-by: jess <jesslarkdev+gh@gmail.com> * identifier: tweaks and additions to slur list (bluesky-social#1319) * Refactor appview repo subscription for memleak (bluesky-social#1308) * refactor to remove closure in loop * move consecutive item out of p-queue * Handle validation improvements (bluesky-social#1336) * Handle matches and false positives for unacceptable words in handles * move handle validation logic to pds * missed merge * add cfg flag * encode lists * fix build issues * move words to cfg * tidy --------- Co-authored-by: Jaz Volpert <ericvolp12@gmail.com> * Allow moderators to take and reverse actor takedowns (bluesky-social#1330) allow moderators to take and reverse actor takedowns * ✨ Allow searching reports by moderator did (bluesky-social#1283) * ✨ Allow searching reports by moderator did * ✅ Remove .only flags on tests * ✅ Update snapshot * ✅ Add checks for did match in actions * v0.4.1 * Make sequencer leader behavior optional on pds (bluesky-social#1250) * make sequencer leader behavior optional on pds * tidy * use 127.0.0.1 in with-test-db.sh for colima (bluesky-social#1297) So, since Docker Desktop has licensing issues, some folks use colima for running containers on their macOS machines (The licensing exempted CLI-only version of Docker only exists on Linux). Unfortunately, colima binds host ports only on the IPv4 localhost address (`127.0.0.1`) while the atproto postgres clients will attempt to connect to the IPv6 localhost address (`::1`) that macOS sets in /etc/hosts. See abiosoft/colima#583 and lima-vm/lima#1330 for the tickets against colima. (Docker Desktop binds to both IPv4 and IPv6 localhost addresses and so doesn't have this issue.) To workaround this silly issue, we can use `localhost` within the docker containers and docker-compose, but need to set the `DB_POSTGRES_URL` env var to use the IPv4 localhost explicitly. (Asking folks to edit /etc/hosts causes other tools to break and will be overridden on each OS upgrade.) * Subscription util tests (bluesky-social#1295) * consecutive list tests * flesh out subscription util tests --------- Co-authored-by: Devin Ivy <devinivy@gmail.com> * Content reporting on record fields (bluesky-social#1351) * content reporting on record fields * fix test * tests * tidy * Check rkey contents just for non-tids (bluesky-social#1353) check rkey content for non-tids * ✨ Added new procedure for sending admin email (bluesky-social#1312) * 🚧 Added new lexicon for sending admin email * ✨ Add moderation mailer * ✨ Switch to text email content from html * 🧹 Cleanup some early implementation code and reflect PR reivew * ✨ Use smtp host instead of gmail service config * ✨ Move to using single smtp url * v0.4.2 * Patch up a couple sqlite tests (bluesky-social#1355) patch up a couple sqlite tests * enable feeds & build branch * disable branch building & enable without proxy header --------- Co-authored-by: Devin Ivy <devinivy@gmail.com> Co-authored-by: David Buchanan <d@vidbuchanan.co.uk> Co-authored-by: jess <jesslarkdev+gh@gmail.com> Co-authored-by: bnewbold <bnewbold@robocracy.org> Co-authored-by: Jaz Volpert <ericvolp12@gmail.com> Co-authored-by: Foysal Ahamed <cfaion341@gmail.com> Co-authored-by: Jeff Hodges <jeff@somethingsimilar.com>
mloar
pushed a commit
to mloar/atproto
that referenced
this pull request
Sep 26, 2023
* refactor appview services * tidy types * Allow moderators to take and reverse actor takedowns (bluesky-social#1330) allow moderators to take and reverse actor takedowns * ✨ Allow searching reports by moderator did (bluesky-social#1283) * ✨ Allow searching reports by moderator did * ✅ Remove .only flags on tests * ✅ Update snapshot * ✅ Add checks for did match in actions * v0.4.1 * Make sequencer leader behavior optional on pds (bluesky-social#1250) * make sequencer leader behavior optional on pds * tidy * use 127.0.0.1 in with-test-db.sh for colima (bluesky-social#1297) So, since Docker Desktop has licensing issues, some folks use colima for running containers on their macOS machines (The licensing exempted CLI-only version of Docker only exists on Linux). Unfortunately, colima binds host ports only on the IPv4 localhost address (`127.0.0.1`) while the atproto postgres clients will attempt to connect to the IPv6 localhost address (`::1`) that macOS sets in /etc/hosts. See abiosoft/colima#583 and lima-vm/lima#1330 for the tickets against colima. (Docker Desktop binds to both IPv4 and IPv6 localhost addresses and so doesn't have this issue.) To workaround this silly issue, we can use `localhost` within the docker containers and docker-compose, but need to set the `DB_POSTGRES_URL` env var to use the IPv4 localhost explicitly. (Asking folks to edit /etc/hosts causes other tools to break and will be overridden on each OS upgrade.) * Subscription util tests (bluesky-social#1295) * consecutive list tests * flesh out subscription util tests --------- Co-authored-by: Devin Ivy <devinivy@gmail.com> * Content reporting on record fields (bluesky-social#1351) * content reporting on record fields * fix test * tests * tidy * Check rkey contents just for non-tids (bluesky-social#1353) check rkey content for non-tids * ✨ Added new procedure for sending admin email (bluesky-social#1312) * 🚧 Added new lexicon for sending admin email * ✨ Add moderation mailer * ✨ Switch to text email content from html * 🧹 Cleanup some early implementation code and reflect PR reivew * ✨ Use smtp host instead of gmail service config * ✨ Move to using single smtp url * v0.4.2 * Patch up a couple sqlite tests (bluesky-social#1355) patch up a couple sqlite tests * Increase appview keepalive (bluesky-social#1360) increase keepalive to 90s * Appview - serve feed skeletons (bluesky-social#1265) * proxy timeline skeleton construction to appview * add getFeedSkeleton to appview * mount route * smart proxy feed skeletons * tests * proper error code * only proxy specific feeds * build branch * update proxyable feed logic, should use feed publisher rather than generator * fix feed proxy tests, configure feed publisher (in addition to generator) * hotfix: prevent user-supplied rkey on posts with createRecord (bluesky-social#1313) * prevent user-supplied rkey on posts with createRecord * allow empty-string rkey parameter Co-authored-by: devin ivy <devinivy@gmail.com> --------- Co-authored-by: devin ivy <devinivy@gmail.com> * add slurs to reserved words (bluesky-social#1318) * add slurs to reserved words (bluesky-social#1314) * Update reserved.ts Add slurs to reserved words * Update reserved.ts fix typo * Update reserved.ts to clean up the slur list * linting * pluralise --------- Co-authored-by: jess <jesslarkdev+gh@gmail.com> * identifier: tweaks and additions to slur list (bluesky-social#1319) * Refactor appview repo subscription for memleak (bluesky-social#1308) * refactor to remove closure in loop * move consecutive item out of p-queue * Handle validation improvements (bluesky-social#1336) * Handle matches and false positives for unacceptable words in handles * move handle validation logic to pds * missed merge * add cfg flag * encode lists * fix build issues * move words to cfg * tidy --------- Co-authored-by: Jaz Volpert <ericvolp12@gmail.com> * Allow moderators to take and reverse actor takedowns (bluesky-social#1330) allow moderators to take and reverse actor takedowns * ✨ Allow searching reports by moderator did (bluesky-social#1283) * ✨ Allow searching reports by moderator did * ✅ Remove .only flags on tests * ✅ Update snapshot * ✅ Add checks for did match in actions * v0.4.1 * Make sequencer leader behavior optional on pds (bluesky-social#1250) * make sequencer leader behavior optional on pds * tidy * use 127.0.0.1 in with-test-db.sh for colima (bluesky-social#1297) So, since Docker Desktop has licensing issues, some folks use colima for running containers on their macOS machines (The licensing exempted CLI-only version of Docker only exists on Linux). Unfortunately, colima binds host ports only on the IPv4 localhost address (`127.0.0.1`) while the atproto postgres clients will attempt to connect to the IPv6 localhost address (`::1`) that macOS sets in /etc/hosts. See abiosoft/colima#583 and lima-vm/lima#1330 for the tickets against colima. (Docker Desktop binds to both IPv4 and IPv6 localhost addresses and so doesn't have this issue.) To workaround this silly issue, we can use `localhost` within the docker containers and docker-compose, but need to set the `DB_POSTGRES_URL` env var to use the IPv4 localhost explicitly. (Asking folks to edit /etc/hosts causes other tools to break and will be overridden on each OS upgrade.) * Subscription util tests (bluesky-social#1295) * consecutive list tests * flesh out subscription util tests --------- Co-authored-by: Devin Ivy <devinivy@gmail.com> * Content reporting on record fields (bluesky-social#1351) * content reporting on record fields * fix test * tests * tidy * Check rkey contents just for non-tids (bluesky-social#1353) check rkey content for non-tids * ✨ Added new procedure for sending admin email (bluesky-social#1312) * 🚧 Added new lexicon for sending admin email * ✨ Add moderation mailer * ✨ Switch to text email content from html * 🧹 Cleanup some early implementation code and reflect PR reivew * ✨ Use smtp host instead of gmail service config * ✨ Move to using single smtp url * v0.4.2 * Patch up a couple sqlite tests (bluesky-social#1355) patch up a couple sqlite tests * enable feeds & build branch * disable branch building & enable without proxy header --------- Co-authored-by: Devin Ivy <devinivy@gmail.com> Co-authored-by: David Buchanan <d@vidbuchanan.co.uk> Co-authored-by: jess <jesslarkdev+gh@gmail.com> Co-authored-by: bnewbold <bnewbold@robocracy.org> Co-authored-by: Jaz Volpert <ericvolp12@gmail.com> Co-authored-by: Foysal Ahamed <cfaion341@gmail.com> Co-authored-by: Jeff Hodges <jeff@somethingsimilar.com> * add optional ilike query to getPopularFeedGenerators * fix lint * fix lint * handle sqlite too in pds only * fix lint * v0.4.3 * Include takendown posts for admins (feature branch) (bluesky-social#1361) * 🚧 WIP including takendown posts on author feed * ✨ Add takedown id on posts when including taken down posts * 🧹 Cleanup the auth verifier and other bsky package code * ✅ Add test for admin getAuthorFeed * 🧹 Cleanup lexicon and exclude takedownId * more explicit plumbing for post hydration w/o requester or with takedown info * pass along flag for soft-deleted actors * cleanup getAuthorFeed w/ auth * reorg getAuthorFeed logic around role/access-based auth --------- Co-authored-by: Foysal Ahamed <cfaion341@gmail.com> * ✨ Disable signing up with invite code from takendown account (bluesky-social#1350) * fix viewer data --------- Co-authored-by: Devin Ivy <devinivy@gmail.com> Co-authored-by: Foysal Ahamed <cfaion341@gmail.com> Co-authored-by: Jeff Hodges <jeff@somethingsimilar.com> Co-authored-by: David Buchanan <d@vidbuchanan.co.uk> Co-authored-by: jess <jesslarkdev+gh@gmail.com> Co-authored-by: bnewbold <bnewbold@robocracy.org> Co-authored-by: Jaz Volpert <ericvolp12@gmail.com> Co-authored-by: Eric Bailey <git@esb.lol>
mloar
pushed a commit
to mloar/atproto
that referenced
this pull request
Nov 15, 2023
* add slurs to reserved words (bluesky-social#1314) * Update reserved.ts Add slurs to reserved words * Update reserved.ts fix typo * Update reserved.ts to clean up the slur list * linting * pluralise --------- Co-authored-by: jess <jesslarkdev+gh@gmail.com>
mloar
pushed a commit
to mloar/atproto
that referenced
this pull request
Nov 15, 2023
* proxy timeline skeleton construction to appview * add getFeedSkeleton to appview * mount route * smart proxy feed skeletons * tests * proper error code * only proxy specific feeds * build branch * update proxyable feed logic, should use feed publisher rather than generator * fix feed proxy tests, configure feed publisher (in addition to generator) * hotfix: prevent user-supplied rkey on posts with createRecord (bluesky-social#1313) * prevent user-supplied rkey on posts with createRecord * allow empty-string rkey parameter Co-authored-by: devin ivy <devinivy@gmail.com> --------- Co-authored-by: devin ivy <devinivy@gmail.com> * add slurs to reserved words (bluesky-social#1318) * add slurs to reserved words (bluesky-social#1314) * Update reserved.ts Add slurs to reserved words * Update reserved.ts fix typo * Update reserved.ts to clean up the slur list * linting * pluralise --------- Co-authored-by: jess <jesslarkdev+gh@gmail.com> * identifier: tweaks and additions to slur list (bluesky-social#1319) * Refactor appview repo subscription for memleak (bluesky-social#1308) * refactor to remove closure in loop * move consecutive item out of p-queue * Handle validation improvements (bluesky-social#1336) * Handle matches and false positives for unacceptable words in handles * move handle validation logic to pds * missed merge * add cfg flag * encode lists * fix build issues * move words to cfg * tidy --------- Co-authored-by: Jaz Volpert <ericvolp12@gmail.com> * Allow moderators to take and reverse actor takedowns (bluesky-social#1330) allow moderators to take and reverse actor takedowns * ✨ Allow searching reports by moderator did (bluesky-social#1283) * ✨ Allow searching reports by moderator did * ✅ Remove .only flags on tests * ✅ Update snapshot * ✅ Add checks for did match in actions * v0.4.1 * Make sequencer leader behavior optional on pds (bluesky-social#1250) * make sequencer leader behavior optional on pds * tidy * use 127.0.0.1 in with-test-db.sh for colima (bluesky-social#1297) So, since Docker Desktop has licensing issues, some folks use colima for running containers on their macOS machines (The licensing exempted CLI-only version of Docker only exists on Linux). Unfortunately, colima binds host ports only on the IPv4 localhost address (`127.0.0.1`) while the atproto postgres clients will attempt to connect to the IPv6 localhost address (`::1`) that macOS sets in /etc/hosts. See abiosoft/colima#583 and lima-vm/lima#1330 for the tickets against colima. (Docker Desktop binds to both IPv4 and IPv6 localhost addresses and so doesn't have this issue.) To workaround this silly issue, we can use `localhost` within the docker containers and docker-compose, but need to set the `DB_POSTGRES_URL` env var to use the IPv4 localhost explicitly. (Asking folks to edit /etc/hosts causes other tools to break and will be overridden on each OS upgrade.) * Subscription util tests (bluesky-social#1295) * consecutive list tests * flesh out subscription util tests --------- Co-authored-by: Devin Ivy <devinivy@gmail.com> * Content reporting on record fields (bluesky-social#1351) * content reporting on record fields * fix test * tests * tidy * Check rkey contents just for non-tids (bluesky-social#1353) check rkey content for non-tids * ✨ Added new procedure for sending admin email (bluesky-social#1312) * 🚧 Added new lexicon for sending admin email * ✨ Add moderation mailer * ✨ Switch to text email content from html * 🧹 Cleanup some early implementation code and reflect PR reivew * ✨ Use smtp host instead of gmail service config * ✨ Move to using single smtp url * v0.4.2 * Patch up a couple sqlite tests (bluesky-social#1355) patch up a couple sqlite tests * enable feeds & build branch * disable branch building & enable without proxy header --------- Co-authored-by: Devin Ivy <devinivy@gmail.com> Co-authored-by: David Buchanan <d@vidbuchanan.co.uk> Co-authored-by: jess <jesslarkdev+gh@gmail.com> Co-authored-by: bnewbold <bnewbold@robocracy.org> Co-authored-by: Jaz Volpert <ericvolp12@gmail.com> Co-authored-by: Foysal Ahamed <cfaion341@gmail.com> Co-authored-by: Jeff Hodges <jeff@somethingsimilar.com>
mloar
pushed a commit
to mloar/atproto
that referenced
this pull request
Nov 15, 2023
* refactor appview services * tidy types * Allow moderators to take and reverse actor takedowns (bluesky-social#1330) allow moderators to take and reverse actor takedowns * ✨ Allow searching reports by moderator did (bluesky-social#1283) * ✨ Allow searching reports by moderator did * ✅ Remove .only flags on tests * ✅ Update snapshot * ✅ Add checks for did match in actions * v0.4.1 * Make sequencer leader behavior optional on pds (bluesky-social#1250) * make sequencer leader behavior optional on pds * tidy * use 127.0.0.1 in with-test-db.sh for colima (bluesky-social#1297) So, since Docker Desktop has licensing issues, some folks use colima for running containers on their macOS machines (The licensing exempted CLI-only version of Docker only exists on Linux). Unfortunately, colima binds host ports only on the IPv4 localhost address (`127.0.0.1`) while the atproto postgres clients will attempt to connect to the IPv6 localhost address (`::1`) that macOS sets in /etc/hosts. See abiosoft/colima#583 and lima-vm/lima#1330 for the tickets against colima. (Docker Desktop binds to both IPv4 and IPv6 localhost addresses and so doesn't have this issue.) To workaround this silly issue, we can use `localhost` within the docker containers and docker-compose, but need to set the `DB_POSTGRES_URL` env var to use the IPv4 localhost explicitly. (Asking folks to edit /etc/hosts causes other tools to break and will be overridden on each OS upgrade.) * Subscription util tests (bluesky-social#1295) * consecutive list tests * flesh out subscription util tests --------- Co-authored-by: Devin Ivy <devinivy@gmail.com> * Content reporting on record fields (bluesky-social#1351) * content reporting on record fields * fix test * tests * tidy * Check rkey contents just for non-tids (bluesky-social#1353) check rkey content for non-tids * ✨ Added new procedure for sending admin email (bluesky-social#1312) * 🚧 Added new lexicon for sending admin email * ✨ Add moderation mailer * ✨ Switch to text email content from html * 🧹 Cleanup some early implementation code and reflect PR reivew * ✨ Use smtp host instead of gmail service config * ✨ Move to using single smtp url * v0.4.2 * Patch up a couple sqlite tests (bluesky-social#1355) patch up a couple sqlite tests * Increase appview keepalive (bluesky-social#1360) increase keepalive to 90s * Appview - serve feed skeletons (bluesky-social#1265) * proxy timeline skeleton construction to appview * add getFeedSkeleton to appview * mount route * smart proxy feed skeletons * tests * proper error code * only proxy specific feeds * build branch * update proxyable feed logic, should use feed publisher rather than generator * fix feed proxy tests, configure feed publisher (in addition to generator) * hotfix: prevent user-supplied rkey on posts with createRecord (bluesky-social#1313) * prevent user-supplied rkey on posts with createRecord * allow empty-string rkey parameter Co-authored-by: devin ivy <devinivy@gmail.com> --------- Co-authored-by: devin ivy <devinivy@gmail.com> * add slurs to reserved words (bluesky-social#1318) * add slurs to reserved words (bluesky-social#1314) * Update reserved.ts Add slurs to reserved words * Update reserved.ts fix typo * Update reserved.ts to clean up the slur list * linting * pluralise --------- Co-authored-by: jess <jesslarkdev+gh@gmail.com> * identifier: tweaks and additions to slur list (bluesky-social#1319) * Refactor appview repo subscription for memleak (bluesky-social#1308) * refactor to remove closure in loop * move consecutive item out of p-queue * Handle validation improvements (bluesky-social#1336) * Handle matches and false positives for unacceptable words in handles * move handle validation logic to pds * missed merge * add cfg flag * encode lists * fix build issues * move words to cfg * tidy --------- Co-authored-by: Jaz Volpert <ericvolp12@gmail.com> * Allow moderators to take and reverse actor takedowns (bluesky-social#1330) allow moderators to take and reverse actor takedowns * ✨ Allow searching reports by moderator did (bluesky-social#1283) * ✨ Allow searching reports by moderator did * ✅ Remove .only flags on tests * ✅ Update snapshot * ✅ Add checks for did match in actions * v0.4.1 * Make sequencer leader behavior optional on pds (bluesky-social#1250) * make sequencer leader behavior optional on pds * tidy * use 127.0.0.1 in with-test-db.sh for colima (bluesky-social#1297) So, since Docker Desktop has licensing issues, some folks use colima for running containers on their macOS machines (The licensing exempted CLI-only version of Docker only exists on Linux). Unfortunately, colima binds host ports only on the IPv4 localhost address (`127.0.0.1`) while the atproto postgres clients will attempt to connect to the IPv6 localhost address (`::1`) that macOS sets in /etc/hosts. See abiosoft/colima#583 and lima-vm/lima#1330 for the tickets against colima. (Docker Desktop binds to both IPv4 and IPv6 localhost addresses and so doesn't have this issue.) To workaround this silly issue, we can use `localhost` within the docker containers and docker-compose, but need to set the `DB_POSTGRES_URL` env var to use the IPv4 localhost explicitly. (Asking folks to edit /etc/hosts causes other tools to break and will be overridden on each OS upgrade.) * Subscription util tests (bluesky-social#1295) * consecutive list tests * flesh out subscription util tests --------- Co-authored-by: Devin Ivy <devinivy@gmail.com> * Content reporting on record fields (bluesky-social#1351) * content reporting on record fields * fix test * tests * tidy * Check rkey contents just for non-tids (bluesky-social#1353) check rkey content for non-tids * ✨ Added new procedure for sending admin email (bluesky-social#1312) * 🚧 Added new lexicon for sending admin email * ✨ Add moderation mailer * ✨ Switch to text email content from html * 🧹 Cleanup some early implementation code and reflect PR reivew * ✨ Use smtp host instead of gmail service config * ✨ Move to using single smtp url * v0.4.2 * Patch up a couple sqlite tests (bluesky-social#1355) patch up a couple sqlite tests * enable feeds & build branch * disable branch building & enable without proxy header --------- Co-authored-by: Devin Ivy <devinivy@gmail.com> Co-authored-by: David Buchanan <d@vidbuchanan.co.uk> Co-authored-by: jess <jesslarkdev+gh@gmail.com> Co-authored-by: bnewbold <bnewbold@robocracy.org> Co-authored-by: Jaz Volpert <ericvolp12@gmail.com> Co-authored-by: Foysal Ahamed <cfaion341@gmail.com> Co-authored-by: Jeff Hodges <jeff@somethingsimilar.com> * add optional ilike query to getPopularFeedGenerators * fix lint * fix lint * handle sqlite too in pds only * fix lint * v0.4.3 * Include takendown posts for admins (feature branch) (bluesky-social#1361) * 🚧 WIP including takendown posts on author feed * ✨ Add takedown id on posts when including taken down posts * 🧹 Cleanup the auth verifier and other bsky package code * ✅ Add test for admin getAuthorFeed * 🧹 Cleanup lexicon and exclude takedownId * more explicit plumbing for post hydration w/o requester or with takedown info * pass along flag for soft-deleted actors * cleanup getAuthorFeed w/ auth * reorg getAuthorFeed logic around role/access-based auth --------- Co-authored-by: Foysal Ahamed <cfaion341@gmail.com> * ✨ Disable signing up with invite code from takendown account (bluesky-social#1350) * fix viewer data --------- Co-authored-by: Devin Ivy <devinivy@gmail.com> Co-authored-by: Foysal Ahamed <cfaion341@gmail.com> Co-authored-by: Jeff Hodges <jeff@somethingsimilar.com> Co-authored-by: David Buchanan <d@vidbuchanan.co.uk> Co-authored-by: jess <jesslarkdev+gh@gmail.com> Co-authored-by: bnewbold <bnewbold@robocracy.org> Co-authored-by: Jaz Volpert <ericvolp12@gmail.com> Co-authored-by: Eric Bailey <git@esb.lol>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a tweak on #1314 so that we pass CI linting