Include own replies to own post roots via new filter posts_and_author_threads

[estrattonbailey]

Update here: to avoid breaking any other clients, we've opted to keep posts_no_replies as-is, and add a new posts_and_author_threads filter that includes the logic needed by the frontend. I'll make another corresponding frontend PR to update the filter param.

Original post below.

---

Since we moved posts_no_replies logic to the backend, we've lacked self-threads on the default "Posts" view of profiles.

This PR expands that query to include replies, but ONLY if those replies are (1) by the author you're viewing and (2) their reply root is a post by the author you're viewing.

As noted in bluesky-social/social-app#1166 (comment), this results in returning replies that are "detached" from the root by a post by another user. That part will be handled on the frontend for now, at least until we move to our new backend architecture.

[mary-ext]

could there be an additional condition where the replyParent also starts with at://${actorDid}/ if it matches the replyRoot startswith?

I'm a little wary that as it is now, it could be catastrophic for profiles whose content is primarily dominated by A <- B <- A sort of replies (e.g. certain clusters like the doll cluster is pretty used to making daily greetings with each other)

so by adding this condition, apps could just focus on filtering out the very edge case scenario as noted in bluesky-social/social-app#1166 (comment)

[estrattonbailey]

Hey @mary-ext 👋

could there be an additional condition

If I understand what you're asking, yeah, a replyParent could have been written by the same actor and could match too. But that replyParent would also have a replyRoot that would match, so this check should capture both.

could be catastrophic for profiles

Could you elaborate on what would happen in this case? For A -> B -> A reply trees, this PR should flatten them to only return A -> A. The logic here is (intended to be, anyway): get all posts and reposts for an actor, PLUS any replies for an actor that are written by the actor in response to a "root" post by the same actor.

The frontend will then filter out any "detached" threads, as mentioned in bluesky-social/social-app#1166 (comment). The result should be that a user should see only posts, reposts, and their own unbroken threads.

I'll double check on this stuff! Thanks for the comment, lmk if I'm off-base or not making sense 😄

[mary-ext]

ah, let me visualize it this way then

Alice -> makes a good morning post
  Bob
    Alice
  Natalie
    Alice
  Devon
    Alice
  Naomi
    Alice
  ... so on

from the query that I'm seeing in this PR, Alice's replies to everyone else would make it onto post_no_replies as it's still under the same thread root, and therefore have to be filtered away by the client, or is there something I'm not getting at here?

edit: ohh, but then I suppose filtering it then would make it impossible to work around the edge case in bluesky-social/social-app#1166 (comment) wouldn't it?

[estrattonbailey]

@mary-ext yep exactly, you're correct. This PR will include all replies by Alice and send them down to the frontend.

The frontend then does the rest of the work. For now, we're going filter out any posts that are not part of an un-broken chain back to a root post by the user. So for the edge case here bluesky-social/social-app#1166 (comment), the reply by Bob and the two replies to Bob from Alice will not appear on Alice's posts_no_replies tab.

[dholms]

guess this codegen just didn't quite make it into a previous PR?

wanna make sure this PR contains the correct content & not main

[dholms]

sweet this looks great 👌