-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Social proof #2548
Merged
estrattonbailey
merged 5 commits into
bluesky-social:social-proof
from
dirkmc:social-proof
Jun 6, 2024
Merged
Social proof #2548
estrattonbailey
merged 5 commits into
bluesky-social:social-proof
from
dirkmc:social-proof
Jun 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* attach hosting status to entryway session responses * integrate account deactivation in with entryway * tidy * tidy * chnageset * update changeset
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Thanks @dirkmc! Gonna merge into the base and take it from here 👍 |
estrattonbailey
pushed a commit
that referenced
this pull request
Jun 6, 2024
* Update deactivation through updateSubjectStatus (#2539) * attach hosting status to entryway session responses * integrate account deactivation in with entryway * tidy * tidy * chnageset * update changeset * Version packages (#2546) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * lexicon: initial social proof lexicons * feat: add generated types for social proof * feat: social proof implementation --------- Co-authored-by: Daniel Holmgren <dtholmgren@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Devin Ivy <devinivy@gmail.com>
estrattonbailey
pushed a commit
that referenced
this pull request
Jun 7, 2024
* Update deactivation through updateSubjectStatus (#2539) * attach hosting status to entryway session responses * integrate account deactivation in with entryway * tidy * tidy * chnageset * update changeset * Version packages (#2546) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * lexicon: initial social proof lexicons * feat: add generated types for social proof * feat: social proof implementation --------- Co-authored-by: Daniel Holmgren <dtholmgren@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Devin Ivy <devinivy@gmail.com>
dholms
added a commit
that referenced
this pull request
Jun 11, 2024
* lexicon: initial social proof lexicons * Social proof (#2548) * Update deactivation through updateSubjectStatus (#2539) * attach hosting status to entryway session responses * integrate account deactivation in with entryway * tidy * tidy * chnageset * update changeset * Version packages (#2546) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * lexicon: initial social proof lexicons * feat: add generated types for social proof * feat: social proof implementation --------- Co-authored-by: Daniel Holmgren <dtholmgren@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Devin Ivy <devinivy@gmail.com> * Rename * Codegen * Implementation, renaming * Remove only * Add depth resolution param, update snaps * Be smart like Devin * Snaps * Revert lock changes * Snaps * Snaps * Snaps * Add changeset * Snaps * Revert lock changes * Add test for basic profile * Add getKnownFollowersEndpoint * Make it zero * Return max of 5 * Remove isNoHosted * Use array and index * Clarify ternary * Remove includeKnownFollowers from views * Revert "Return max of 5" This reverts commit 1a27eb7. * Ope missed a param * Rename view method * Don't return viewer if undefined * Format * Clean up hydrator * Snaps * Update proto, use batch endpoint * Format * Fix proto, codegen * Remove unneeded promise * Move hydrator into route handler * Add hydrationLogger * Handle failures of dataplane getKnownFollowers * Use .at(), defer to params.limit * Create instance of FollowsFollowing for better type support * Support knownFollowers in mergeStates * Add back fat-fingered deleted imports * Filter out blocks * Codegen lex * Naive block filtering * Remove whitespace edits * Update changeset desc * Remove whitespace --------- Co-authored-by: Devin Ivy <devinivy@gmail.com> Co-authored-by: dirkmc <dirkmdev@gmail.com> Co-authored-by: Daniel Holmgren <dtholmgren@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you view a user’s profile we’d like to provide some details about followers of the given account that you follow. This establishes social connections between the two users, and we hope that it will facilitate users discovering their broader clusters and ultimately following each other. Here’s an example:
This PR adds a
socialProof
to theviewer
section of the profile, eg:The PR implements
getFollowsFollowing({ actorDid, targetDid })
method at the data-plane layer, that returns a list of didssocialProof
element of theProfileViewerState
with acount
andfollows
for the first 5 dids returned from the data-plane layerHydrationState