Social proof #2557
Social proof #2557
Conversation
estrattonbailey
force-pushed
the
social-proof
branch
2 times, most recently
from
cc99a1f to
569c40a
Compare
* Update deactivation through updateSubjectStatus (#2539) * attach hosting status to entryway session responses * integrate account deactivation in with entryway * tidy * tidy * chnageset * update changeset * Version packages (#2546) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * lexicon: initial social proof lexicons * feat: add generated types for social proof * feat: social proof implementation --------- Co-authored-by: Daniel Holmgren <dtholmgren@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Devin Ivy <devinivy@gmail.com>
estrattonbailey
force-pushed
the
social-proof
branch
from
1f4712c to
6f68cf7
Compare
packages/bsky/src/views/index.ts
Outdated
| const followers = mapDefined(knownFollowers.followers, (did) => { | ||
| return this.profileBasic(did, state) | ||
| }) | ||
| return { count: knownFollowers.count, followers } |
There was a problem hiding this comment.
I believe that there is a minimum of one item for followers. It would be nice to have some logic enforcing that colocated around here, or perhaps drop the requirement from the lexicon if you think the frontend wont mind.
We may also want to consider enforcing blocks, and possibly mutes, in this list.
There was a problem hiding this comment.
We updated this the other day to 0. Yeah I'll make sure frontend can handle it, no issue there.
Yeah should def filter out blocks, I think mutes are OK to leave in though.
There was a problem hiding this comment.
Ya know, hadn't codegenned though, glad you brought this up.
Blocks are now filtered, added a test
| const knownFollowers = carolForAlice.data.viewer?.knownFollowers | ||
| expect(knownFollowers?.count).toBe(1) | ||
| expect(knownFollowers?.followers).toHaveLength(0) |
There was a problem hiding this comment.
Just noting here count is 1, but the blocked user has been filtered out. We return 5 to the client, and the client uses only 3, so we're already overfetching. Discussed with Devin and decided this was a rare enough case to leave in for now. Frontend will handle the difference.
Adds
knownFollowerstoViewerStateonProfileDetailedviews. This includes:getProfilesgetProfilegetSuggestedFollowsByActorgetSuggestionsAlso adds
getKnownFollowersmethod that returns the full list of known followers for a givenactor. This is set up for pagination, but is not actually paginated atm due to dataplane constraints.