Update changeset to better reflect changes #2707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinivy
reviewed
Aug 12, 2024
.changeset/silver-buckets-hope.md
Outdated
Comment on lines
1
to
6
| --- | ||
| "@atproto/lex-cli": minor | ||
| "@atproto/xrpc-server": patch | ||
| --- | ||
|
|
||
| Updated to use refactored version of `@atproto/xrpc`. |
There was a problem hiding this comment.
If this is truly just a dependency update then we don't need a changeset for it, as changesets will detect this and add a line to the changelog. E.g. like this: https://github.com/bluesky-social/atproto/blob/main/packages/dev-env/CHANGELOG.md#0338
There was a problem hiding this comment.
Ah that's right, the lex-cli changes are more in-depth and are an actual breaking change.
devinivy
reviewed
Aug 12, 2024
.changeset/rude-drinks-relate.md
Outdated
| "@atproto/pds": patch | ||
| --- | ||
|
|
||
| Updated to use refactored version of `@atproto/api`. |
There was a problem hiding this comment.
Same here, if it's truly just for a version update then changesets will detect that and add a note to the changelog automatically.
There was a problem hiding this comment.
Certainly wont do any harm though, so not terribly worried about it!
devinivy
approved these changes
Aug 12, 2024
devinivy
approved these changes
Aug 12, 2024
Merged
estrattonbailey
added a commit
that referenced
this pull request
Aug 15, 2024
* origin/main: Provide a ponyfill for CustomEvent (#2710) Ensure presence of DPoP related response headers (#2711) prettier ignore changelogs, as changesets not resolving prettier config properly Version packages (#2709) Export `AtpAgentOptions` type from @atproto/api (#2708) tidy Version packages (#2706) Update changeset to better reflect changes (#2707) Client SDK rework (#2483) Allow aud of pds or entryway for service auth tokens on pds (#2694) Version packages (#2692) Lex-cli prettier changes changeset (#2691) Version packages (#2689) PDS - inspect bearer tokens (#2688) Version packages (#2685) Service auth method binding - PDS (#2668) minor typos in descriptions and comments (#2681) Fix run-dev-env-logged command (#2682) Version packages (#2677) Tweak some wording in `oauth-client-browser` readme (#2678)
haileyok
pushed a commit
that referenced
this pull request
Aug 16, 2024
* Update changeset to better reflect changes * Remove un-necessary packages from changeset * codegen * expose lexicons instead of schemas * export a copy of the internal lexicon * typo * fix minor typos in changesets --------- Co-authored-by: Devin Ivy <devinivy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.