Align OAuth 2FA code handling with social-app #2825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just so you know, for most browsers this would usually have been fine but this appears to be a very long standing Webkit bug! |
|
Oh huh, I didn't realise! |
matthieusieben
approved these changes
Sep 23, 2024
surfdude29
reviewed
Sep 23, 2024
packages/oauth/oauth-provider/src/assets/app/components/sign-in-form.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: surfdude29 <149612116+surfdude29@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bluesky-social/social-app#5448
The email OTP code we send is in lowercase for some reason - I'll try and fix that as well, but in social-app it tries some basic corrections on the code in case someone types it by hand. This PR uses the same function that social-app uses, which uppercases it and adds the dash in the middle if it's not present.
Note
social-app uses the regex
/^[A-Z2-7]{5}-[A-Z2-7]{5}$/, whereas I found oauth was using the slightly more lax/^[A-Z0-9]{5}-[A-Z0-9]{5}$/. I replaced it with social-app's one, I hope that's ok?