Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use uppercase 2fa codes in email templates #2843

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Use uppercase 2fa codes in email templates #2843

merged 2 commits into from
Sep 30, 2024

Conversation

estrattonbailey
Copy link
Member

Ensures codes are uppercased, since that's what our app expects. We could also loosen those regexes to allow lowercase i.e. [A-z] but let's just stick to the script.

Fixes #2825 and bluesky-social/social-app#5448

@estrattonbailey estrattonbailey merged commit 2788203 into main Sep 30, 2024
10 checks passed
@estrattonbailey estrattonbailey deleted the email-template-codes branch September 30, 2024 22:18
estrattonbailey added a commit that referenced this pull request Sep 30, 2024
@estrattonbailey
Merge remote-tracking branch 'origin/main' into samuel/pin-others
9a8c3a4 
* origin/main:
  Use uppercase 2fa codes in email templates (#2843)
  Fix Promise generic in oauth-client README (#2839)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dholms dholms dholms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@estrattonbailey @dholms