Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APP-786] Native notifications #1095

Merged
merged 29 commits into from
Aug 23, 2023
Merged

Conversation

ansh
Copy link
Contributor

@ansh ansh commented Aug 3, 2023

Related to bluesky-social/atproto#1428
Pull the above branch, build using yarn and then use the dist from the api package instead of the current one

To test on Android, you also require google-services.json from Firebase

(lint errors exist because of the above)

addNotificationResponseReceivedListener will not run in dev mode, so please start the frontend server in production with npx expo start --no-dev --minify

There are no regressions in this PR, however there are a few improvements that can be made in the future, but aren't implemented because they need more discussion:

  • Deeplink to a post when clicking on a notification (right now it just goes to the notifications screen)
  • Display images in notifications when the post has an image
  • Potentially display notifications when app is in foreground

@ansh ansh marked this pull request as draft August 3, 2023 01:54
@ansh ansh marked this pull request as ready for review August 10, 2023 02:01
@pfrazee
Copy link
Collaborator

pfrazee commented Aug 15, 2023

PR seems fine so far. Let's get backend merged and the API changes published, then we can test this in testflight. Until the backend stuff is in prod, testflight doesn't do us much good.

Copy link
Collaborator

@pfrazee pfrazee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🔔

@pfrazee pfrazee merged commit 8ab5eb6 into main Aug 23, 2023
@pfrazee pfrazee deleted the ansh/app-786-native-notifications branch August 23, 2023 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants