[Session] Extract resumeSession out #3811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-3811.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-coph53vsc6pc7388dd40. |
gaearon
commented
May 2, 2024
| }, [initSession]) | ||
|
|
||
| useEffect(() => { | ||
| return listenSessionDropped(() => { |
There was a problem hiding this comment.
Fixed to return the unsub, I think this was previously leaking.
|
haileyok
approved these changes
May 2, 2024
There was a problem hiding this comment.
Encountered the incorrect pinned feeds issue once when switching back and forth between accounts, but appears to be the existing issue rather than a new one. Switching accts works, and account is loaded before splash disappears (tested just setting isReady to false and watched the logs).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resumeSessionis a thin wrapper overinitSessionwhich setssetIsInitialLoad(false)to hide the splash and then becomes effectively the same asinitSession. I was wondering if I could get rid of it, and the only usage ofresumeSessionwas from top-levelInnerAppcomponents which, conveniently, were the ones who neededisInitialLoadin the first place (to hide the splash). So I removedresumeSessionfrom the Session API and removedisInitialLoadfrom its context.Why?
I want to pare it down, and
resumeSessiondoesn't depend on any knowledge that isn't already available through the Session API. So it made sense to me to move it out to keep that code more focused. Conceptually we have one instance of theInnerAppcomponent (it's just forked between two platforms). The local usage also makes sense because it lets us get rid of context for something that's really a very local thing that only one component cares about.Test Plan
Verify splash screen still gets hidden on session init. Verify switching users still works.