[Session] Extract selectAccount out #3812
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to #3811 in spirit and is based on the same insight.
selectAccount
has nothing to do with session management per se, it's just a wrapper aroundinitSession
that tracks the progress of that call. It makes sense to make such state tracking local to where the action was triggered in the UI code. So I'm moving that state back into components.I moved the
isSwitchingAccounts
state variable out of the Session API and into the calling components which now callinitSession
directly. ForAccountList
, I've plumbed it down from the component that owns the switch press handler.Test Plan
Use the account switcher, both the popover and the settings one. It feels a bit janky but I replicated the existing logic. This should make it a bit easier to change the UI logic if we'd like to later because it's all local state now.