-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Threaded composer #3813
[WIP] Threaded composer #3813
Conversation
using index is prone to double-firing, for some reason
Worst part of threads is having to use unroll bot, or clicking through replies to get to next commented reply, esp on those with 10+ posts. So I think it would be great if threads are marked as such, instead of just posting as tweets and replies. This way someone could post the entire tweet of 1000 words in one box, get to see how and where breakpoints would be applied, modify those if they wish. And from readers side, one click option in 3 dot settings to unroll or view full post can make things lot easier. |
@Spacedesolate that's pretty much out of scope for this work regardless if this makes it in or not (I'm just an outside contributor, I have no insight over Bluesky's roadmap or what the team intends to do) consider making a new issue next time ^^ |
Ooooh this is a very bold feature to pick up. We are interested in it. I'm quite worried that it's going to take some extensive testing and edgecase handling, and that we'll end up letting it languish because we're focusing on other things. My worst-case outcome is that you do a bunch of work that we don't honor. Let me talk to the crew tomorrow. Regarding the mobx, that's just there because we were afraid to mess with the code. We do want to ditch it, it's just a finicky system. |
Chatted with the team. We're pretty excited for this feature, and we think the approach you're taking -- putting the changes in a separate component -- makes this work pretty well. That keeps it safe from conflicts during its development. So: if you're keen to keep working on this, we absolutely welcome it! |
Nice! I'll see if I can figure out a nice way to tackle the image manipulation, since that's really the only major thing blocking this at the moment |
Wrapped up with implementing DMs on my own Bluesky client, so I'm going to pick this up again, rebasing off 8a12b60 |
Closing in favor of #4163 |
Checklist
Bonus checklist
Problem
Archived
2024-05-02.13-15-46.mp4