-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite composer image state management, remove MobX #3925
Conversation
…k-bsky-app into mary-ext-refactor/mobx-image
Your Render PR Server URL is https://social-app-pr-3925.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cou5u0mv3ddc73enholg. |
The Pull Request introduced fingerprint changes against the base commit: 55ac287 Fingerprint diff[{"type":"file","filePath":"package.json","reasons":["expoConfigPlugins"],"hash":"5bfc50879ff239e0c12cf79f3eed104b39baf3ec"}] Generated by PR labeler 🤖 |
|
The new modals might make it easy to accidentally lose work if one manages to overshoot their mouse cursor while moving/resizing the crop area around. I'll have to update #3884 to get it to work for the new modals as well if we still want to close on backdrop click but not on the case I just mentioned |
Supersedes #3890 by @mary-ext.
Original PR description:
Decided to do this separately from #3813, removes the only remaining MobX dependency from the app.
{cacheDirectory}/bsky-composer
, this folder is set to purge when the composer is closed. I feel this is a worthwhile approach compared to making sure that images are being purged properly every time it's being manipulated.react-avatar-editor
has been replaced withreact-image-crop
which is slightly more workable. Would've preferred one that also does fixed cropping butreact-easy-crop
is being finicky with initial states.Additions