-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Threaded composer v2 #4163
Conversation
…k-bsky-app into mary-ext-refactor/mobx-image
this fixes the double .focus() it seems
Sick! Look forward to giving it all a look. |
Between the many Indonesian users moving in, there are a decent amount of fanfic authors looking for threaded composer and drafts. I think it might be worth making this happen soon (with drafts being easy to add in afterwards), let me know if there's anything else I can help with on getting this pushed forwards. Cheers! |
Nope! We will wrap this fairly soon
|
It's been three months and now the Brazilians are flooding the platform. Guess it's time to finally review and hopefully merge. Please. |
Now that video is cooked, how about giving this the push it needs? 🙏 |
There's been a lot of changes to the composer itself since this PR was made, and I need to find the time to work on rebasing the changes. For now though, I'd recommend just using posteing instead |
Good news is that I should have some time to spare on rebasing this PR, problem is, we'd still need to get #3925 merged first (I'll need to rebase this as well, but if that's blocked, this one's blocked) |
a8c06b3
to
7c5a182
Compare
Ayy, we're finally getting to parity (aside from UI) in #5962. Huge thanks for getting this started — no way I'd be able to figure out how to do it without your work here. |
Continuation of #3813, moved to a separate branch since this one is being based over 8a12b60
Actual composer-related changes starting from 36ec7fe, with the newer changes starting bb355d0
UI looks more or less the same as before though
Checklist
Notable changes
embed
fieldrecordWithMedia
record
andexternal
embeds are now handled by React Query, post submission no longer needs to be disabled as we try to retrieve details for the embed, since we can also retrieve them as part of the post submission process itself.record
embed can now be added after addingexternal
embed, previously this wasn't possible becauserecord
embeds had to go through the same process asexternal
embeds, and doing so would just override theexternal
embed before it settles as arecord
embedrecord
embeds now show a proper preview for lists and feeds in particular.image
andexternal
embeds, I think right now this makes a lot more sense since the only globals labels that exists are for media embeds only. This also means that labels are no longer persisted when embeds are being swapped for another, which might better match user expectations.Additional questions