[🐴] Handle deleted accounts, restructure ChatListItem #4114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-4114.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cp5mou0cmk4c738rf4lg. |
|
* origin/main: Update French localization (#4113) Update Japanese translations (#3886) Update pt-BR localization to latest version (#4009) Update zh-CN translations (#3932) Update zh-TW translations (#4025) Update Korean localization (#4030) Update catalan messages.po (#4079) Update Spanish Localization (#4105) Allow removal of feeds that fail to load (#4121) [🐴] Make message input layout resizing synchronous (#4123) [🐴] Adjust content height whenever the emoji picker keyboard is opened or closed (#4120) Conditionally set chat declaration (#4122) [🐴] Fix load state for disabled chats (#4119) Bump api sdk (#4118) [🐴] Switch back to encouraging users to report messages (#4117) convo button skeleton (#4115) [🐴] Screenreader accessibility actions for individual chat items (#4116) [🐴] DM button on profile (#4097) [🐴] Don't retry sends (#4111)
haileyok
reviewed
May 20, 2024
Comment on lines
+148
to
+155
| onPress={ | ||
| isDeletedAccount | ||
| ? e => { | ||
| e.preventDefault() | ||
| return false | ||
| } | ||
| : undefined | ||
| } |
There was a problem hiding this comment.
Cool for now, but we should make this a prop on our new link maybe, I've had to do this a few times before. Just something for later.
haileyok
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review without whitespace: https://github.com/bluesky-social/social-app/pull/4114/files?diff=split&w=1
Deleted accounts delete all messages for both parties, so there's no need to load the Convo screen. This PR disables that link.
This PR also converts to a
Linkfor better a11y, and restructures theChatListItemso that the context menu is outside theLinkfor better a11y. It should also fix some alignment issues we had with deleted accounts.