Detect keycode for keyDown in Safari's IME
#4186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-4186.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cp7br5uv3ddc73cl2nrg. |
remove debug logs use a better hack implement a safari hack extract `isSafari` and `isFirefox` to a global variable
haileyok
force-pushed
the
hailey/safari-ime
branch
from
3499770 to
2c70d1c
Compare
|
mozzius
approved these changes
May 23, 2024
gaearon
approved these changes
May 23, 2024
estrattonbailey
added a commit
that referenced
this pull request
May 23, 2024
* origin/main: Remove `getProfile` calls when loading feed (#3881) Log error statuses from failed resume session calls (#4174) disable alt text auto focus on Android (#4198) [🐴] add link to chat settings from main settings (#4197) ✍️ Add OTA Docs (#4187) Decrease thickness of border on message input (#4196) [🐴] better error message for "Bad token scope" error (#4194) Add padding to dialogs when keyboard is open on Android (#4182) [🐴] Do not init event bus if no session (#4193) stop line breaks for timeelapsed (#4191) Reduce polling when app is backgrounded (#4192) implement a safari hack for ime (#4186) [🐴] Suspend event bus when switching accounts (#4190)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fixes #4178
Chrome, Firefox, etc. handle the IME very well. If the IME is visible and the key is the enter key, it just dismisses the IME and inserts whatever selection into the input. Naturally though, Safari must not have the same behavior, otherwise our jobs would be too simple.
Specifically, on other browsers,
onCompositionEndis fired after theonKeyDownevent is fired. This means that ourisComposingvalue is still true when we decide whether to submit the message or not. However, on Safari,onCompositionEndis fired before!Therefore, on Safari, we can check if the
Enterpress has a keycode of229. If it does, we do not submit the message.I also moved the
isSafariandisFirefoxchecks into a separate filebrowsers.tsand made abrowsers.native.tsversion that just returns false. We are using these a little more and they are getting duplicated, so might as well add them to one place. I didn't want to use the existingconstants.tssince we won't have a.webversion of that file.Test Plan
Same as other browser for IME. Enable the IME, and type some text. Press the enter key to see if it submits or does not. With this PR, Safari should not submit on enter press while the IME is still open.
Screen.Recording.2024-05-22.at.8.52.18.PM.mov