[🙅] Add deactivate account dialog #4290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-4290.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cpcffh674orc738p5ob0. |
|
|
I realise it's a draft PR and the copy will change but I have one quick suggestion for you to consider – if feeds and lists from the account will also no longer be visible after a user has deactivated (which I'm assuming will be the case?) I think it would be helpful to mention that here as well: |
gaearon
approved these changes
May 31, 2024
estrattonbailey
force-pushed
the
deactivate/setting
branch
from
d8faae5 to
fc716d5
Compare
estrattonbailey
force-pushed
the
deactivate/setting
branch
from
fc716d5 to
be47ead
Compare
estrattonbailey
merged commit 1a6929f
into
deactivate/disambiguate
5 of 6 checks passed
gaearon
pushed a commit
that referenced
this pull request
Jun 4, 2024
* Disambiguation of the deactivation * Snapshot crackle pop * Change log context * [🙅] Add status to session state (#4269) * Add status to session state * [🙅] Add new deactivated screen (#4270) * Add new deactivated screen * Update copy, handle logout * Remove icons, adjust padding * [🙅] Add deactivate account dialog (#4290) * Deactivate dialog (cherry picked from commit 33940e2) * Factor out dialog, add to delete modal too (cherry picked from commit 47d70f6) * Update copy, icon (cherry picked from commit e6efabb) * Update copy (cherry picked from commit abb0ce2) * Sizing tweaks (cherry picked from commit fc716d5) * Add a11y label
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the dialog as its own button on the Settings screen, and accessible from within the delete account dialog.