Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[🙅] Disambiguation of the deactivation #4267

Merged
merged 7 commits into from
Jun 4, 2024
Merged

[🙅] Disambiguation of the deactivation #4267

merged 7 commits into from
Jun 4, 2024

Conversation

estrattonbailey
Copy link
Member

@estrattonbailey estrattonbailey commented May 29, 2024 •
edited
Loading

We want to call user account deactivation... deactivation. What we previously called deactivated will now be called signupQueued, so I updated everything to reflect that to avoid confusion in upcoming PRs.

Because this functionality isn't used atm, it's safe to merge this and do a clean swap without waiting for backend.

@render Render
Copy link

render bot commented May 29, 2024

Your Render PR Server URL is https://social-app-pr-4267.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-cpbree63e1ms73egg3bg.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 29, 2024 •
edited
Loading

Old size New size Diff
7.24 MB 7.39 MB 154.43 KB (2.08%)

@estrattonbailey estrattonbailey mentioned this pull request May 30, 2024
Merged
@KuwaLee
Copy link
Contributor

KuwaLee commented May 30, 2024

Sorry to bother you, but I encountered difficulty while translating left to go. string, since I am wondering it is place left so you can enroll or place where you line in (that you have to wait).

Plus, I think make it {placeInQueue} left to go instead of left to go. will let it more translatable since it will not fix {placeInQueue} at front

@estrattonbailey
Copy link
Member Author

@KuwaLee good question! Here placeInQueue means the number of users ahead of you in line. This is separate from the amount of time it will take. Example: 12 left to go means there are 12 users ahead of you.

As for the formatting, I'm not sure we can because we use separate text components to style these string values. Is that OK? I will double check with folks also and maybe update.

@estrattonbailey
[🙅] Add status to session state (#4269)
80a2099 
* Add status to session state

* [🙅] Add new deactivated screen (#4270)

* Add new deactivated screen

* Update copy, handle logout

* Remove icons, adjust padding
@estrattonbailey
[🙅] Add deactivate account dialog (#4290)
1a6929f 
* Deactivate dialog

(cherry picked from commit 33940e2)

* Factor out dialog, add to delete modal too

(cherry picked from commit 47d70f6)

* Update copy, icon

(cherry picked from commit e6efabb)

* Update copy

(cherry picked from commit abb0ce2)

* Sizing tweaks

(cherry picked from commit fc716d5)
@estrattonbailey
Add a11y label
0766d71
@estrattonbailey
Merge remote-tracking branch 'origin/main' into deactivate/disambiguate
e60308e 
* origin/main: (37 commits)
  fix accessibility label in notifications (#4305)
  [🐴] add emoji multiplier prop to RichText and bump it up for DMs (#4229)
  Tweak avi follow button styles (#4304)
  [🐴] Embed backwards compat (#4302)
  [🐴] Add labels to chats (#4293)
  [🐴] Option to share via chat in post dropdown (#4231)
  [🐴] Record message (#4230)
  [🐴] send record via link in text (Record DMs - base PR) (#4227)
  Use new icons on notifications screen (#4299)
  Composer - fix modals, and other tweaks (#4298)
  Shadows (#4265)
  Change many border widths from `1` to `hairlineWidth` (#4294)
  Add follow button to feed item avatar (#3560)
  Disable non-deterministic flaky test (#4295)
  Don't log downsample warning when unnecessary (#4291)
  [Statsig] Sample noisy events (#4288)
  Bump FontAwesome (#4285)
  Fix scrolling for labeler profiles (#4286)
  Reduce Threadgate button size (#4287)
  put dropdown in fullscreenoverlay on iOS (#4284)
  ...
@estrattonbailey estrattonbailey force-pushed the deactivate/disambiguate branch from 22a6410 to e60308e Compare May 31, 2024 21:35
@gaearon gaearon merged commit 3e1f076 into main Jun 4, 2024
12 checks passed
@gaearon gaearon deleted the deactivate/disambiguate branch June 4, 2024 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaearon gaearon gaearon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@estrattonbailey @KuwaLee @gaearon