Fix (#4430): Use separate hooks for shell mode animated styles #4451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it would be a bit simpler if we kept them in the same file. Makes it easier to add/delete variants. |
gaearon
approved these changes
Jun 10, 2024
|
Argh, I'm sorry you had to make the requested changes yourself @gaearon! Anyway, I'm happy I helped improving the performance a bit! 🚀 |
|
no worries! |
estrattonbailey
added a commit
that referenced
this pull request
Jun 11, 2024
* origin/main: (54 commits) patch `expo-notifications` to clear badge (#4475) Revert to old modal on android (#4458) Sort profile feedgens by likes (#4380) Revert "Fix undefined block (#4471)" (#4472) Fix undefined block (#4471) Open convo menu when tapping on chat with deleted account (#4470) stop using `addPushTokenListener` (#4467) add hitslop to repost button (#4469) Add a loading indicator to notifications when loading latest (#4468) Visually improve the empty state of feeds (#4466) Give a meaningful error in the composer when replying to a deleted post (#4464) Fix: show known feed error UI more reliably (#4463) Only validate persisted data for existing users (#4465) Check `canAskAgain` for notification permissions (#4460) Add support for new-tab clicks on feeds (#4462) Override legacy language codes for indonesian, hebrew, and yiddish (#4461) Ungate mobile web notification badge (#4459) Fix (#4430): Use separate hooks for shell mode animated styles (#4451) Throttle instead of debounce (#4456) debounce refetching listconvos (#4455) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a silly "move stuff around" PR and is small step towards improving the perceived performance on low end devices.
This PR is based on the findings reported in #4430 and replaces the hook
useMinimalShellModewith 3 separate hooks dedicated to building the animated style (for footer, header and Fab buttons)This avoids creating 3 instances of the hook
useAnimatedStyleof which only one is actually needed every time the hook is used, and reduces the first render time for components using the transitions on low end Android devices.I tested for regressions for both iOS and web too, and found none, hence I updated the
.webcomponents aswell for consistency, but I'm not 100% familiar with simultaneous web/mobile development using RN so let me know if it's ok.Also, I preferred to keep 3 hooks in the base
hooksfolder but I'm ok with equivalent alternatives.Fixes #4430